Page MenuHomePhabricator
Create Task
Maniphest T90606

Avoid cache fragmenting URLs for Share a Fact shares
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently, the apps share URLs by adding a query to the URL:

?source=app

?source=app should be changed to the following:

iOS: ?wprov=sfii1 for image cards, ?wprov=sfti1 for text shares
Android: ?wprov=sfia1 for image cards, ?wprov=sfta1 for text shares

In iOS, WMFShareOptionsViewController (init, respondToTapForCardGesture, and respondToTapForTextGesture) should be updated accordingly.

In Android, ShareHandler.java should be updated.

Additionally, a VCL patch should be submitted in the fashion of https://gerrit.wikimedia.org/r/#/c/120617/, but generalized for handling this wprov parameter with an alphanumeric value.

Details

ProjectBranchLines +/-Subject
apps/android/wikipediamaster+4 -1Avoid cache fragmenting URLs for Share a Fact shares
Customize query in gerrit

Related Objects

Event Timeline

dr0ptp4kt created this task.Feb 24 2015, 5:43 PM
dr0ptp4kt raised the priority of this task from to Needs Triage.
dr0ptp4kt updated the task description. (Show Details)
dr0ptp4kt added projects: Analytics, acl*sre-team, Mobile-Apps, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog.
dr0ptp4kt added subscribers: dr0ptp4kt, BBlack, faidon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2015, 5:43 PM
dr0ptp4kt triaged this task as Medium priority.Feb 25 2015, 12:36 AM
dr0ptp4kt added a project: Blocked-on-Operations.Feb 25 2015, 6:39 PM
dr0ptp4kt set Security to None.
dr0ptp4kt added a project: Scrum-of-Scrums.Feb 25 2015, 6:46 PM
dr0ptp4kt moved this task from Scheduled to blocked by Operations on the Scrum-of-Scrums board.Feb 25 2015, 6:56 PM
• KLans_WMF moved this task from Needs Triage to Needs Estimation on the Wikipedia-iOS-App-Backlog board.Feb 26 2015, 6:19 PM
• KLans_WMF added a project: Mobile App Sprint 52 - iOS.
• KLans_WMF moved this task from Needs Estimation to In Development on the Wikipedia-iOS-App-Backlog board.Mar 2 2015, 5:34 PM
• KLans_WMF moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Mar 2 2015, 10:35 PM
dr0ptp4kt added a comment.Mar 4 2015, 5:04 PM

@BBlack, okay if we model after https://gerrit.wikimedia.org/r/#/c/120617/ ?

• DarTar added a subscriber: • DarTar.Mar 4 2015, 6:06 PM
Deskana removed a project: Mobile-Apps.Mar 10 2015, 4:19 PM
dr0ptp4kt added a comment.Mar 10 2015, 6:00 PM

The format of the parameter will be as follows:

?wprov=<3_char_feature><platform_one_char><major_version_of_feature_uint>

For the first version on iOS, this will be

?wprov=safi1

And Android:

?wprov=safa1

dr0ptp4kt removed a project: Blocked-on-Operations.Mar 11 2015, 4:01 PM
dr0ptp4kt moved this task from blocked by Operations to In progress on the Scrum-of-Scrums board.
dr0ptp4kt added a comment.EditedMar 11 2015, 4:23 PM

There's an update. See https://lists.wikimedia.org/pipermail/analytics/2015-March/003583.html.

it will be

iOS: ?wprov=sfii1 for image cards, ?wprov=sfti1 for text shares
Android: ?wprov=sfia1 for image cards, ?wprov=sfta1 for text shares

• DarTar added a comment.Mar 11 2015, 4:51 PM

@dr0ptp4kt, awesome, can you document this parameter scheme somewhere on mediawiki.org or wikitech for future reference?

• Fjalapeno added a subscriber: • Fjalapeno.Mar 11 2015, 10:29 PM

I was going to pick this up but its not clear what the actual issue is from the ticket description.

@dr0ptp4kt I assume you intended on picking this up, but even so, we should make sure the descriptions provide enough explanation for anyone to complete (and also not rely on parsing email threads for details).

dr0ptp4kt added a comment.Mar 11 2015, 11:14 PM

I'll update the ticket description.

dr0ptp4kt updated the task description. (Show Details)Mar 11 2015, 11:23 PM
• Fjalapeno added a comment.Mar 12 2015, 3:40 PM

@dr0ptp4kt thanks!

• Fjalapeno claimed this task.Mar 12 2015, 3:40 PM
• Fjalapeno moved this task from To Do to Doing on the Mobile App Sprint 52 - iOS board.
gerritbot added a subscriber: gerritbot.Mar 12 2015, 3:41 PM

Change 196243 had a related patch set uploaded (by Fjalapeno):
Addresses Bug:T90606 Now using different url parameters for sharing types.

https://gerrit.wikimedia.org/r/196243

gerritbot added a project: Patch-For-Review.Mar 12 2015, 3:41 PM
• Fjalapeno moved this task from Doing to Code Review on the Mobile App Sprint 52 - iOS board.Mar 12 2015, 3:41 PM
gerritbot added a comment.Mar 12 2015, 5:29 PM

Change 196243 merged by Dr0ptp4kt:
Addresses Bug:T90606 Now using different url parameters for sharing types.

https://gerrit.wikimedia.org/r/196243

dr0ptp4kt added a comment.Mar 12 2015, 5:30 PM

The iOS client side code is good. Merged that in.

• Fjalapeno mentioned this in rAPIW85fdd44cae7a: Addresses Bug:T90606 Now using different url parameters for sharing types..Mar 12 2015, 5:30 PM
dr0ptp4kt claimed this task.Mar 12 2015, 5:31 PM
dr0ptp4kt removed dr0ptp4kt as the assignee of this task.
dr0ptp4kt moved this task from Code Review to To Do on the Mobile App Sprint 52 - iOS board.
dr0ptp4kt edited a custom field.
• Fjalapeno moved this task from To Do to Ready for Signoff on the Mobile App Sprint 52 - iOS board.Mar 12 2015, 7:41 PM
yuvipanda added a subscriber: yuvipanda.Mar 14 2015, 8:40 AM

This needs a VCL patch as well.

dr0ptp4kt edited projects, added Mobile-App-Sprint-53-Android; removed Mobile App Sprint 52 - iOS.Mar 19 2015, 5:52 PM
dr0ptp4kt edited projects, added Mobile-App-Sprint-53-iOS; removed Mobile-App-Sprint-53-Android.
dr0ptp4kt claimed this task.Mar 19 2015, 5:56 PM
dr0ptp4kt moved this task from To Do to Doing on the Mobile-App-Sprint-53-iOS board.
dr0ptp4kt moved this task from Doing to Code Review on the Mobile-App-Sprint-53-iOS board.Mar 23 2015, 7:44 PM

https://gerrit.wikimedia.org/r/#/c/198805/ under review.

dr0ptp4kt added a comment.Mar 23 2015, 8:40 PM

Reserved codes now listed at https://www.mediawiki.org/wiki/Provenance

dr0ptp4kt added a comment.Mar 23 2015, 9:49 PM

The iOS code update was https://gerrit.wikimedia.org/r/#/c/196243/, by the way.

gerritbot added a comment.Mar 23 2015, 10:06 PM

Change 199140 had a related patch set uploaded (by BearND):
Avoid cache fragmenting URLs for Share a Fact shares

https://gerrit.wikimedia.org/r/199140

gerritbot added a comment.Mar 23 2015, 11:58 PM

Change 199140 merged by Dr0ptp4kt:
Avoid cache fragmenting URLs for Share a Fact shares

https://gerrit.wikimedia.org/r/199140

• bearND mentioned this in rAPAWd49b39879cda: Avoid cache fragmenting URLs for Share a Fact shares.Mar 24 2015, 5:39 PM
dr0ptp4kt added a comment.Mar 24 2015, 11:08 PM

https://gerrit.wikimedia.org/r/#/c/198805/ submitted for review for Varnish.

BBlack mentioned this in rOPUPfb4205ccc384: Do not fragment cache with provenance parameter.Mar 26 2015, 9:00 PM
dr0ptp4kt moved this task from Code Review to Done on the Mobile-App-Sprint-53-iOS board.Mar 27 2015, 12:19 PM
mark added a project: Varnish.Apr 8 2015, 11:18 AM
mark added a subscriber: mark.
dr0ptp4kt closed this task as Resolved.Apr 8 2015, 4:16 PM
• DarTar added a subscriber: Deskana.Apr 9 2015, 7:02 PM

@dr0ptp4kt, @Deskana: are there related plans for appending an oldid parameter and reviewing the caching implications or has that option been abandoned?

Deskana added a comment.Apr 9 2015, 7:03 PM
In T90606#1195594, @DarTar wrote:

@dr0ptp4kt, @Deskana: are there related plans for appending an oldid parameter and reviewing the caching implications or has that option been abandoned?

That's still on the table, and we plan to revisit this soon. I have no ETA at this time, though.

• DarTar added a comment.Apr 9 2015, 7:05 PM

@Deskana got it, I'd like to run past you some ideas about the backlink that I discussed with Moiz and a few accessibility folks.

Deskana added a comment.Apr 9 2015, 7:06 PM

@DarTar That sounds great. Putting it in an email or a Phab task would be ideal, as I'm really overloaded with work at the minute.

Deskana moved this task from In Development to Resolved/Invalid/Declined/Legacy on the Wikipedia-iOS-App-Backlog board.Apr 23 2015, 4:55 AM
Dbrant moved this task from Tracking to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Sep 28 2015, 4:00 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 28 2015, 4:00 PM
Aklapper added a project: Traffic.May 4 2016, 9:14 AM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:54 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL