Page MenuHomePhabricator

Special:UserProfile has unclosed div which destroy the page view
Closed, ResolvedPublic

Description

It seems that the <div id="mw-content-text"> on Special:UserProfile (in the desktop version) is not closed which gives invalid html and destroy the page view (overlapping icons over the content).

Event Timeline

Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender subscribed.

What's the use of this useless page anyway? It ain't my profile, not even remotely (That's my user page). It's ugly as f***, I fail to see any purpose for this "merkbefreite" (observationally challenged) page.

Is there a way to opt out of this travesty?

What's the use of this useless page anyway? It ain't my profile, not even remotely (That's my user page). It's ugly as f***, I fail to see any purpose for this "merkbefreite" (observationally challenged) page.

Is there a way to opt out of this travesty?

Please create an own task to ask your question. Thanks.

Please create an own task to ask your question. Thanks.

Done: T90753

Someone didn't like my figurative language and I had to restart it ;)

I haven't been able to reproduce this bug. The HTML looks valid and the page seems to display fine. (Testing desktop version.) Can anyone else verify? If so, a screenshot would be useful.

Here's what my "profile" looks like:

Spezial:Benutzerprofil_Sänger.png (748×811 px, 66 KB)

This seems to happen on dewiki, but not on enwiki, meta or zhwiki.

This seems to happen on dewiki, but not on enwiki, meta or zhwiki.

Strange, but you seem to be right:

https://meta.wikimedia.org/wiki/Special:UserProfile/Sänger_S.G looks as intended ("right" would be the wrong word ;)
https://en.wikimedia.org/wiki/Special:UserProfile/Sänger_S.G as well
https://nl.wikimedia.org/wiki/Speciaal:Gebruikersprofiel/Sänger_S.G an again
https://de.wikipedia.org/w/index.php?title=Spezial:Benutzerprofil/Sänger_S.G but not here

What's wrong with deWP in this regard?
Or ... better just ditch this no-profile ;)

Due a missing closing div-tag, the header and sidebar (div#mw-navigation) are now within div#content
dewiki has in its MediaWiki:Vector.css, which causes the wrong alignment as seen in the screenshot above.

#content {
	position: relative;
	/* ... */
}

If that's the spot, this unclosed div seems to have been introduced in https://gerrit.wikimedia.org/r/93430/https://phabricator.wikimedia.org/rEMFR1000f2e10a60ea70c9cadf7d6ac0ec068c4989cc (November 2013). It would be surprising that nobody noticed until now.

Change 193299 had a related patch set uploaded (by MZMcBride):
Fix unclosed div in MobileFrontend's Special:UserProfile

https://gerrit.wikimedia.org/r/193299

Change 193299 merged by jenkins-bot:
Fix unclosed div in MobileFrontend's Special:UserProfile

https://gerrit.wikimedia.org/r/193299

Umherirrender assigned this task to MZMcBride.

Fix will be part of Version 1.25wmf20 - see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the timeline