Global user pages must have the direction of the global wiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Wikiklaas
	Feb 24 2015, 6:23 PM

Description

My Meta user page, in English, is adjusted RTL when shown on ar.wikipedia.org. See: https://meta.wikimedia.org/wiki/User:Wikiklaas and https://ar.wikipedia.org/wiki/%D9%85%D8%B3%D8%AA%D8%AE%D8%AF%D9%85:Wikiklaas
I guess English language pages should be adjusted LTR, also on projects that have RTL adjustification. Adding a div with textdir=ltr language=en did not help.

Details

Subject	Repo	Branch	Lines +/-
Set correct lang and dir for parser output	mediawiki/extensions/GlobalUserPage	master	+50 -28
Use 'PageContentLanguage' hook to set proper lang & div attributes	mediawiki/extensions/GlobalUserPage	master	+25 -0
Set an explicit 'wgLanguageCode' entry for metawiki	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T334383: GlobalUserPage footer needs bi-directional isolation or better LTR support
T94306: template from the global wiki is not properly rendered on the global user page in the target wiki

Event Timeline

Wikiklaas created this task.Feb 24 2015, 6:23 PM

Wikiklaas raised the priority of this task from to Needs Triage.

Wikiklaas updated the task description. (Show Details)

Wikiklaas added a project: GlobalUserPage.

Wikiklaas subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2015, 6:23 PM

@Wikiklaas, if I look at your user page at the Arabic Wikipedia now, it appears correctly. Are you sure that it's still a problem?

... That said, it's because of the HTML you added. The extension should add this HTML automatically. If I look at my user page at the Yiddish Wikisource, it's broken - it is RTL, but should be LTR.

You can use mw-content-ltr class.

Yes, and that's what @Wikiklaas did, more or less, but it should be automatic.

Amire80 mentioned this in T94306: template from the global wiki is not properly rendered on the global user page in the target wiki.Mar 28 2015, 5:19 PM

Amire80 added a project: I18n.

Amire80 set Security to None.

To make sure I understand this bug properly, the extension should automatically add <div lang="en" dir="ltr" class="mw-content-ltr"> (and the closing div tag)?

Kind of, but more precisely:

lang must be the page language (getPageLanguage(); in practice equal to the wiki's content language, but this may change in the future)
dir must be the dir of that language (getDir())
class must match the dir

For the case of Wikimedia, it's Meta, and it's en and rtl, but for other installations it may be different.

Thanks for your comments. As you say this should be done automatically, I removed the div for the text-direction. I did now get a Flash Of Unstyled Content, showing the text ltr, but then the rtl Arabic css took over.

Liuxinyu970226 subscribed.Apr 17 2015, 1:19 PM

Aklapper added a project: RTL.Jun 2 2015, 2:20 PM

Izno awarded a token.Jun 25 2015, 8:39 PM

Izno subscribed.

Meno25 subscribed.Jul 9 2015, 2:55 PM

Ladsgroup moved this task from Backlog to MediaWiki-core on the RTL board.Jul 15 2015, 7:48 PM

Amire80 triaged this task as Low priority.Jul 16 2015, 3:12 PM

Change 228617 had a related patch set uploaded (by Legoktm):
Use 'PageContentLanguage' hook to set proper lang & div attributes

https://gerrit.wikimedia.org/r/228617

Change 228618 had a related patch set uploaded (by Legoktm):
Set an explicit 'wgLanguageCode' entry for metawiki

https://gerrit.wikimedia.org/r/228618

Mormegil awarded a token.Dec 16 2016, 10:08 AM

Amire80 renamed this task from LTR pages adjusted RTL on arabic languages to Global user pages must have the direction of the global wiki.Feb 28 2018, 12:29 PM

Restricted Application added a subscriber: alaa. · View Herald TranscriptFeb 28 2018, 12:29 PM

Amire80 moved this task from Untriaged to RTL on the I18n board.Feb 28 2018, 12:29 PM

Meno25 unsubscribed.Nov 23 2018, 8:03 AM

• Phabricator_maintenance removed a parent task: T2745: [DO NOT USE] RTL/bidirectional issues (tracking) [superseded by #RTL].Feb 22 2019, 1:12 PM

Change 228617 abandoned by Legoktm:

[mediawiki/extensions/GlobalUserPage@master] Use 'PageContentLanguage' hook to set proper lang & div attributes

Reason:

Outdated, not working on it

https://gerrit.wikimedia.org/r/228617

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 9 2023, 7:24 PM

MarcoAurelio mentioned this in T334383: GlobalUserPage footer needs bi-directional isolation or better LTR support.Apr 10 2023, 9:57 AM

BrandonXLF subscribed.Apr 11 2023, 5:56 AM

Change 908001 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/extensions/GlobalUserPage@master] Set correct lang and dir for parser output

https://gerrit.wikimedia.org/r/908001

gerritbot added a project: Patch-For-Review.Apr 12 2023, 12:06 AM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptApr 12 2023, 12:06 AM

These two examples seem to work correctly today:

By "correct" I mean, that, they render with dir=ltr lang=en and, specifically, do so while viewing the page on an RTL wiki with a non-English user interface language (i.e. logged-out, or with ?uselang=he). If I misunderstood the issue or if it's still broken for you, feel free to re-open.

Change 908001 abandoned by BrandonXLF: