Page MenuHomePhabricator

Create more granular qunit tests for banner display
Open, MediumPublic

Description

Using test fixtures, qunit covers lots of scenarios, verifying many aspects of the code that targets campaigns and banners. But the tests are mostly integration tests rather than unit tests. This card is about making some more specific, method-centric unit-y tests.

Event Timeline

AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG subscribed.

@AndyRussG is this something you're thinking is a short term need or a note that we've got a hole here until we can circle back to it?

@atgo I think we should circle back to it later. With existing tests we have the code's overall input and output covered for most reasonable scenarios. These more detailed tests would be nice, but they're also dependent on smaller implementation details, many of which actually seem about to change with the new non-S:RI and logging scheme. So I'd recommend holding off until after that's out the gate :) Does that make sense?

atgo triaged this task as Medium priority.Feb 25 2015, 7:32 PM

Absolutely. Adjusting Priority accordingly