Page MenuHomePhabricator

Lead image should be delivered as part of the initial response
Closed, DeclinedPublic

Description

The BannerImage module is initialised and run after the page has loaded. If your connection was slow – gasp – then you'll see the page load and, after some delay, a banner image appear.

If we've detected that the user is on a mobile device, we can deliver the details of images that'll look good in both portrait and landscape as part of the initial response. These details should come from calling the lead images API (T98146).

Event Timeline

phuedx raised the priority of this task from to Needs Triage.
phuedx updated the task description. (Show Details)
phuedx added a project: Readers-Web-Backlog.
phuedx added a subscriber: phuedx.

Change 194777 had a related patch set uploaded (by Bmansurov):
Preload banner images

https://gerrit.wikimedia.org/r/194777

Change 194777 abandoned by Bmansurov:
Alpha: Load banner images on page load

Reason:
T77925

https://gerrit.wikimedia.org/r/194777

lets show low res image as default before load

Change 194777 restored by Bmansurov:
Alpha: Load banner images on page load

https://gerrit.wikimedia.org/r/194777

Hrrm. I'm tempted to close this and invalid and have a story writing session with @JKatzWMF and @KHammerstein about lead images on (mobile) web.

As for @bmansurov's patch, @Jdlrobson and I have raised concerns about the number of API requests being made. Also, I think we both feel that the API being used isn't specialised enough.

Change 194777 abandoned by Bmansurov:
Alpha: Load banner images on page load

Reason:
Looks like we don't need this functionality.

https://gerrit.wikimedia.org/r/194777

This may or may not be superseded by the work on Wikidata-Page-Banner (see T98145). Regardless, this task needs more thought from the whole team. Closing for now…

phuedx renamed this task from Initial banner image should be delivered as part of the initial response to Lead image should be delivered as part of the initial response.Jun 2 2015, 1:59 PM
phuedx reopened this task as Open.
phuedx updated the task description. (Show Details)
Jhernandez triaged this task as Medium priority.Aug 18 2015, 5:45 PM
Jhernandez added a subscriber: Jhernandez.
Jdlrobson claimed this task.

This is resolved in WikidataPageBanner. Since strategically the plan is to use this (see T101108) I'm declining this bug.