Page MenuHomePhabricator
Create Task
Maniphest T90771

Move details-related methods on mw.UploadWizard.prototype to the details step
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Move the rest of detailsSubmit to the controllermediawiki/extensions/UploadWizardmaster+12 -24
Move detailsErrorCount to details step UImediawiki/extensions/UploadWizardmaster+68 -36
Move parts of detailsSubmit to details stepmediawiki/extensions/UploadWizardmaster+73 -43
Customize query in gerrit

Related Objects

Event Timeline

MarkTraceur created this task.Feb 25 2015, 8:01 PM
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added projects: Multimedia, UploadWizard.
MarkTraceur subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2015, 8:01 PM
MarkTraceur added a project: Multimedia-Sprint-2015-02-25.Feb 25 2015, 8:01 PM
MarkTraceur set Security to None.
MarkTraceur edited a custom field.
gerritbot subscribed.Feb 25 2015, 8:30 PM

Change 192873 had a related patch set uploaded (by MarkTraceur):
Move parts of detailsSubmit to details step

https://gerrit.wikimedia.org/r/192873

gerritbot added a project: Patch-For-Review.Feb 25 2015, 8:30 PM
• Gilles assigned this task to MarkTraceur.Feb 26 2015, 4:27 PM
• Gilles subscribed.
MarkTraceur moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-02-25 board.Feb 26 2015, 10:03 PM
gerritbot added a comment.Feb 27 2015, 9:14 PM

Change 193485 had a related patch set uploaded (by MarkTraceur):
Move detailsErrorCount to details step UI

https://gerrit.wikimedia.org/r/193485

• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia-Sprint-2015-02-25 board.Mar 2 2015, 11:18 AM
• Gilles edited projects, added Multimedia-Sprint-2015-03-04; removed Multimedia-Sprint-2015-02-25.Mar 4 2015, 4:52 PM
• Gilles moved this task from Backlog to Reviewed, needs improvements on the Multimedia-Sprint-2015-03-04 board.
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia-Sprint-2015-03-04 board.Mar 6 2015, 4:59 PM
gerritbot added a comment.Mar 6 2015, 9:24 PM

Change 194953 had a related patch set uploaded (by MarkTraceur):
Move the rest of detailsSubmit to the controller

https://gerrit.wikimedia.org/r/194953

gerritbot added a comment.Mar 8 2015, 9:23 AM

Change 192873 merged by jenkins-bot:
Move parts of detailsSubmit to details step

https://gerrit.wikimedia.org/r/192873

MarkTraceur mentioned this in rEUWI2cf43057887b: Move parts of detailsSubmit to details step.Mar 8 2015, 9:24 AM
• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia-Sprint-2015-03-04 board.Mar 9 2015, 9:10 AM
MarkTraceur mentioned this in rMEXT42626e94886e: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:28 AM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia-Sprint-2015-03-04 board.Mar 11 2015, 4:15 PM
• Gilles edited projects, added Multimedia-Sprint-2015-03-11; removed Multimedia-Sprint-2015-03-04.Mar 11 2015, 4:22 PM
• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-11 board.Mar 11 2015, 4:24 PM
• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia-Sprint-2015-03-11 board.Mar 12 2015, 9:12 AM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia-Sprint-2015-03-11 board.Mar 13 2015, 4:12 PM
gerritbot added a comment.Mar 16 2015, 12:26 PM

Change 193485 merged by jenkins-bot:
Move detailsErrorCount to details step UI

https://gerrit.wikimedia.org/r/193485

gerritbot added a comment.Mar 16 2015, 1:08 PM

Change 194953 merged by jenkins-bot:
Move the rest of detailsSubmit to the controller

https://gerrit.wikimedia.org/r/194953

• Gilles added a comment.Mar 16 2015, 1:09 PM

Is there more to do, or should this be moved to "ready for testing"?

• Gilles edited projects, added Multimedia-Sprint-2015-03-18; removed Multimedia-Sprint-2015-03-11.Mar 18 2015, 4:14 PM
• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-18 board.
MarkTraceur mentioned this in rEUWI42c07dc2523b: Move detailsErrorCount to details step UI.Mar 23 2015, 3:51 PM
MarkTraceur mentioned this in rEUWI1acc6b7bfa35: Move the rest of detailsSubmit to the controller.
Diffusion mentioned this in rMEXT0cf7bac6db65: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 23 2015, 3:55 PM
Diffusion mentioned this in rMEXT8f2f3a229f7b: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….
MarkTraceur moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-03-18 board.Mar 23 2015, 4:27 PM
• Gilles closed this task as Resolved.Mar 25 2015, 3:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL