Page MenuHomePhabricator

Formatting of TOC header messed up
Closed, ResolvedPublic

Assigned To
Authored By
kaldari
Feb 25 2015, 9:15 PM
Referenced Files
F47140: beta.png
Feb 25 2015, 9:15 PM
F47142: stable.png
Feb 25 2015, 9:15 PM
F47138: alpha.png
Feb 25 2015, 9:15 PM
F47144: correct.png
Feb 25 2015, 9:15 PM

Description

The formatting of the Table of Contents header is messed up, but it's messed up differently in alpha, beta, and stable. All of them are wrong, however. See screenshots...

alpha:

alpha.png (215×208 px, 10 KB)

beta:

beta.png (211×214 px, 10 KB)

stable:

stable.png (201×205 px, 10 KB)

correct (ignore font size):

correct.png (241×257 px, 14 KB)

Event Timeline

kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari subscribed.
kaldari renamed this task from Formatting of TOC messed up to Formatting of TOC header messed up.Feb 25 2015, 9:16 PM
kaldari updated the task description. (Show Details)
kaldari set Security to None.
kaldari updated the task description. (Show Details)

I came here to report this bug :) It's very noticeable, running Chrome 40 on Windows 7. Otherwise, the redesign looks great!

@phuedx @Jdlrobson It looks like the issues in the beta version are related to the rules for mw-ui-icon-element. Frankly, I'm not sure what to make of the rules for mw-ui-icon-element as they are surprisingly complicated and I'm worried that I'll break some pseudo-element fall-back logic or something if I change them. These rules are really in need of some comments explaining their logic and how much they are needed, e.g. is rule X a fragile hack that may need to be revisited or a solid fix for an issue in an old browser? Would either of you be able to add some comments for these so that it is easier to navigate making future changes?

mw-ui-icon is part of MediaWiki UI which is now deprecated apparently.

Our best bet is probably trying to port them over to OOJS UI now but I have no idea where to start with that, as I don't think this warrants adding the entire library to stable - I'd rather we consumed more of the library before doing that.

Right now top priority should be fixing stable - all those rules are in our codebase, some change must have broken them. I think we can live with broken TOC in beta/alpha for a little longer.

Change 193540 had a related patch set uploaded (by Kaldari):
Fixing Table of Contents formatting on mobile

https://gerrit.wikimedia.org/r/193540

Right now top priority should be fixing stable - all those rules are in our codebase, some change must have broken them. I think we can live with broken TOC in beta/alpha for a little longer.

Agreed.

We need to get together and write an epic that tracks the work to convert everything (?) over to OOJS UI.

Change 193540 merged by jenkins-bot:
Fixing Table of Contents formatting on mobile

https://gerrit.wikimedia.org/r/193540

bmansurov claimed this task.