Page MenuHomePhabricator
Create Task
Maniphest T90815

Implement a way to nest toolbar groups without implementing nesting of toolbar groups
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Trevor's design mockup:

Toolbar-Group-Merging.png (316×755 px, 83 KB)

Details

ProjectBranchLines +/-Subject
VisualEditor/VisualEditormaster+29 -12Fold text style dropdown into basic text style bar in toolbar
oojs/uimaster+217 -32Fake toolbar group nesting
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Feb 25 2015, 11:33 PM
matmarex claimed this task.
matmarex raised the priority of this task from to High.
matmarex updated the task description. (Show Details)
matmarex added projects: VisualEditor, OOUI.
matmarex added a subscriber: • TrevorParscal.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2015, 11:33 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Feb 26 2015, 5:34 PM
matmarex added a comment.Feb 26 2015, 10:25 PM

I don't think the mockup is going to work well in practice, and it would be difficult to implement with the current toolbar code. But there's plenty of unnecessary whitespace we can squish.

gerritbot added a subscriber: gerritbot.Feb 26 2015, 11:01 PM

Change 193282 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] Scrollbar squishing

https://gerrit.wikimedia.org/r/193282

gerritbot added a project: Patch-For-Review.Feb 26 2015, 11:01 PM
gerritbot added a comment.Feb 27 2015, 7:30 PM

Change 193282 abandoned by Bartosz Dziewoński:
[WIP] Scrollbar squishing

https://gerrit.wikimedia.org/r/193282

matmarex renamed this task from Implement a way to squish toolbars when there's not enough horizontal space to Implement a way to nest toolbar groups without implementing nesting of toolbar groups.Feb 27 2015, 7:31 PM
matmarex updated the task description. (Show Details)
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
gerritbot added a comment.Feb 27 2015, 11:25 PM

Change 193484 had a related patch set uploaded (by Bartosz Dziewoński):
Fake toolbar group nesting

https://gerrit.wikimedia.org/r/193484

gerritbot added a project: Patch-For-Review.Feb 27 2015, 11:25 PM
matmarex mentioned this in T74159: OOUI: Toolbar groups should support sub-groups as items (hierarchical, nested menus).Feb 27 2015, 11:41 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Feb 28 2015, 1:05 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 2 2015, 4:37 AM
Jdforrester-WMF added a parent task: T74159: OOUI: Toolbar groups should support sub-groups as items (hierarchical, nested menus).
gerritbot added a comment.Mar 2 2015, 9:14 PM

Change 193282 restored by Bartosz Dziewoński:
[WIP] Scrollbar squishing

Reason:
For T52227.

https://gerrit.wikimedia.org/r/193282

Jdforrester-WMF edited a custom field.Mar 2 2015, 11:40 PM
Jdforrester-WMF lowered the priority of this task from High to Low.Mar 3 2015, 5:54 PM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Mar 4 2015, 4:18 PM
gerritbot added a comment.Mar 4 2015, 10:16 PM

Change 193484 merged by jenkins-bot:
Fake toolbar group nesting

https://gerrit.wikimedia.org/r/193484

• TrevorParscal mentioned this in rGOJU078b762aab13: Fake toolbar group nesting.Mar 4 2015, 10:17 PM
Jdforrester-WMF closed this task as Resolved.Mar 4 2015, 11:06 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.9.0), WMF-deploy-2015-03-11_(1.25wmf21); removed OOjs-UI-next-release.Mar 5 2015, 12:29 AM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 5 2015, 1:42 AM
gerritbot added a comment.Mar 5 2015, 3:16 PM

Change 194526 had a related patch set uploaded (by Bartosz Dziewoński):
Fold text style dropdown into basic text style bar in toolbar

https://gerrit.wikimedia.org/r/194526

gerritbot added a project: Patch-For-Review.Mar 5 2015, 3:16 PM
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 5 2015, 9:45 PM
gerritbot added a comment.Mar 5 2015, 10:56 PM

Change 194526 merged by jenkins-bot:
Fold text style dropdown into basic text style bar in toolbar

https://gerrit.wikimedia.org/r/194526

Jdforrester-WMF mentioned this in rGVEDcba6ffe1bd73: Fold text style dropdown into basic text style bar in toolbar.Mar 5 2015, 10:57 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 10 2015, 4:23 PM
Negative24 added a subscriber: Negative24.Mar 13 2015, 10:08 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:55 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL