Page MenuHomePhabricator

SpecialMobileWatchlist, SpecialMobileContributions, SpecialMobileHistory should not use MobileSpecialPageFeed
Closed, DeclinedPublic

Description

renderFeedItemHtml and renderListHeaderWhereNeeded should be rewritten using server side templates and we should aim to remove the need of the MobileSpecialPageFeed class.

formatComment should probably be rewritten as a static function and moved to MobileHistory or MobileContributions.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2015, 12:06 AM
Jhernandez triaged this task as Medium priority.Aug 17 2015, 12:03 PM
Jhernandez updated the task description. (Show Details)
Jhernandez edited projects, added MobileFrontend; removed Readers-Web-Backlog.
Jhernandez set Security to None.
Jdlrobson lowered the priority of this task from Medium to Low.Jul 21 2016, 8:49 PM
Jdlrobson added a project: Technical-Debt.

We should look and see what happened with the watchlist refactor by Wikimedia DE.

Jdlrobson closed this task as Declined.May 22 2017, 10:12 AM

We don't have capacity to reimplement the watchlist anymore then we currently have. The problem with the current implementation is it directly hits the database rather than making use of an api method provided by core to access to all rows in the watchlist. It thus overlooks things like preferences. Continuing like this is unsustainable.

I will make sure this particular feature is added as a requirement to T109277 which aims to increase code quality of the special watchlist code in core to allow it to be skinned for mobile. At very least that work should give us an api/model of the data in the watchlist and simply override the presentation.

Please bear with me a week or so to do this.
Ps. Not sure if declining or merging as duplicate was appropriate here.