Page MenuHomePhabricator
Create Task
Maniphest T91047

EditorTutorial false arrow position
Closed, ResolvedPublic
Actions

Assigned To
• rmoen
Authored By
Florian
Feb 27 2015, 6:59 AM
Tags
Referenced Files
F100804: Screen_Shot_2015-03-19_at_1.10.33_PM.png
Mar 19 2015, 8:11 PM
F100797: Screen_Shot_2015-03-19_at_1.10.33_PM.png
Mar 19 2015, 8:11 PM
F100799: Screen_Shot_2015-03-19_at_1.10.22_PM.png
Mar 19 2015, 8:11 PM
F100801: Screen_Shot_2015-03-19_at_1.10.09_PM.png
Mar 19 2015, 8:11 PM
F56164: Unbenannt.JPG
Mar 5 2015, 7:55 PM
F48427: Unbenannt.PNG
Feb 27 2015, 6:59 AM
Subscribers
Aklapper
Florian
gerritbot
Jdlrobson
• Jhernandez
• rmoen

Description

It seems, that editor tutorial's arrow (which should be under the edit pencil) is rendered before all page actions are enabled, which results in a false position of it (see image).

Unbenannt.PNG (154×1 px, 15 KB)

Details

SubjectRepoBranchLines +/-
In beta, watchstar loads late and is edit tut is positioned incorrectlymediawiki/extensions/Gathermaster+3 -1
Fixes to the page action tutorialmediawiki/extensions/MobileFrontendmaster+11 -2
Make page action overlay pointer position correctly.mediawiki/extensions/MobileFrontendmaster+22 -9
Correct the arrow position of the editor tutorialmediawiki/extensions/MobileFrontendmaster+18 -9
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Feb 27 2015, 6:59 AM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added a project: Web-Team-Backlog.
Florian subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2015, 6:59 AM
• bmansurov moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Feb 27 2015, 6:54 PM
• bmansurov claimed this task.Mar 5 2015, 6:22 PM
• bmansurov set Security to None.
gerritbot subscribed.Mar 5 2015, 7:38 PM

Change 194574 had a related patch set uploaded (by Bmansurov):
Correct the arrow position of the editor tutorial

https://gerrit.wikimedia.org/r/194574

gerritbot added a project: Patch-For-Review.Mar 5 2015, 7:38 PM
• bmansurov moved this task from Old Unorganized Resolved Tasks to Needs Prioritization on the Web-Team-Backlog board.Mar 5 2015, 7:38 PM
Florian added a comment.Mar 5 2015, 7:55 PM

Unbenannt.JPG (472×1 px, 64 KB)

That's how it looks on pages with bannerImages :/ They normally get loaded after the page is rendered and most of Javascripts are eecuted. This should be fixed, too.

• bmansurov added a comment.Mar 5 2015, 7:56 PM

Good catch, then we should listen to the editor icon location changes. Simply listening to window.resize won't do it.

Florian closed this task as Resolved.Mar 6 2015, 6:42 AM
gerritbot added a comment.Mar 6 2015, 6:43 AM

Change 194574 merged by jenkins-bot:
Correct the arrow position of the editor tutorial

https://gerrit.wikimedia.org/r/194574

• bmansurov mentioned this in rEMFR51065d7d5996: Correct the arrow position of the editor tutorial.Mar 6 2015, 6:43 AM
Diffusion mentioned this in rMEXT3e05bd01f64a: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:28 AM
Jdlrobson reopened this task as Open.EditedMar 19 2015, 8:11 PM
Jdlrobson subscribed.

This is not fixed at all.

Screen_Shot_2015-03-19_at_1.10.33_PM.png (359×1 px, 130 KB)
stable

Screen_Shot_2015-03-19_at_1.10.22_PM.png (217×1 px, 53 KB)
beta

Screen_Shot_2015-03-19_at_1.10.09_PM.png (264×1 px, 49 KB)
alpha

Jdlrobson added a subscriber: • rmoen.Mar 19 2015, 8:20 PM

I've reverted the patch. Stable is okay now, but beta and alpha have positioning problems @rmoen should hopefully be able to fix this.

Jdlrobson added a project: Gather Sprint Diplodocus.Mar 19 2015, 8:20 PM
Jdlrobson added a comment.Mar 19 2015, 9:57 PM

So @rmoen and I chatted about this. The issue is BannerImage causes the window to resize as the image pushes the rest of the content down.
Both BannerImage and the PageActionOverlay subscribe to the resize event, but the BannerImage event runs before the PageActionOverlay resize event so the latter never positions correctly.

Baha's patch solved the above by simply refreshing every second.
I wonder if we could do the above but turn off the timeout when the top is the same as last time.

Also the _position function doesn't seem quite right in beta and alpha and probably needs revisted.

Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Diplodocus board.Mar 19 2015, 10:27 PM
Diffusion mentioned this in rMEXT36213e35607f: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 23 2015, 3:56 PM
Jdlrobson moved this task from Ready for dev to In development on the Gather Sprint Diplodocus board.Mar 23 2015, 10:24 PM
Jdlrobson claimed this task.Mar 23 2015, 10:28 PM
Jdlrobson added a subscriber: • bmansurov.
gerritbot added a comment.Mar 23 2015, 11:12 PM

Change 199155 had a related patch set uploaded (by Jdlrobson):
Make page action overlay pointer position correctly.

https://gerrit.wikimedia.org/r/199155

Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Diplodocus board.Mar 24 2015, 12:40 AM
Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Diplodocus board.Mar 24 2015, 1:01 AM
Jdlrobson moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Diplodocus board.Mar 24 2015, 5:53 PM
gerritbot added a comment.Mar 24 2015, 11:08 PM

Change 199155 merged by jenkins-bot:
Make page action overlay pointer position correctly.

https://gerrit.wikimedia.org/r/199155

Jdlrobson mentioned this in rEMFR5f9e74b989f5: Make page action overlay pointer position correctly..Mar 24 2015, 11:08 PM
Diffusion mentioned this in rMEXT193886d4b400: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 24 2015, 11:09 PM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Diplodocus board.Mar 24 2015, 11:11 PM
Florian merged a task: T93820: Editor Tutorial: Space bewteen banner and editor pencil is always different in stable/beta/alpha.Mar 25 2015, 5:49 PM
Jdlrobson added a comment.Mar 25 2015, 5:52 PM

Mm.. this still seems problematic in alpha & beta
See http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?mobileaction=beta with local storage cleared
http://i.imgur.com/sh01DuJ.png

Jdlrobson moved this task from Ready for signoff to Ready for dev on the Gather Sprint Diplodocus board.Mar 25 2015, 5:52 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Mar 25 2015, 6:30 PM
Jdlrobson added a comment.Mar 25 2015, 7:40 PM

Mmm.. the positioning seems to have no method to its madness. Here are some tests I just ran...

For watchstar:
beta: push left by 18px
alpha: pushed up by 60px, push left by 18px

For edit guider (must be logged in)
Stable: needs to be pushed left -204px http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Albert_Einstein&mobileaction=stable&article_action=signup-edit&welcome=yes
Beta: needs to be pushed left by -52px [http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Albert_Einstein&mobileaction=beta&article_action=signup-edit&welcome=yes]
Alpha: pushed up by 40px, pushed right by 8px [http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Albert_Einstein&mobileaction=alpha&article_action=signup-edit&welcome=yes]

• rmoen claimed this task.Mar 25 2015, 9:33 PM
• rmoen moved this task from Ready for dev to In development on the Gather Sprint Diplodocus board.
gerritbot added a comment.Mar 25 2015, 11:47 PM

Change 199795 had a related patch set uploaded (by Robmoen):
In beta, watchstar loads late and is edit tut is positioned incorrectly

https://gerrit.wikimedia.org/r/199795

• rmoen added a comment.Mar 25 2015, 11:48 PM

Also related patch https://gerrit.wikimedia.org/r/#/c/199747/ for centering the arrow on the element.

• rmoen moved this task from In development to Code review needed on the Gather Sprint Diplodocus board.Mar 25 2015, 11:48 PM
Jdlrobson added a comment.Mar 26 2015, 12:40 AM

@rmoen turns out my issue was chrome specific when the star is green.. see... https://phabricator.wikimedia.org/T93987

This works but please see my follow up for other edge cases.

• rmoen mentioned this in rMEXT0f3fb218986d: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 26 2015, 12:43 AM
• rmoen mentioned this in rEMFR356b665a52dc: Center ContentOverlay arrow alignment on element.
gerritbot added a comment.Mar 26 2015, 1:11 AM

Change 199812 had a related patch set uploaded (by Jdlrobson):
Fixes to the page action tutorial

https://gerrit.wikimedia.org/r/199812

• Jhernandez subscribed.Mar 26 2015, 11:37 AM

Seems to work much better than before. Moving to signoff

• Jhernandez moved this task from Code review needed to Ready for signoff on the Gather Sprint Diplodocus board.Mar 26 2015, 11:37 AM
gerritbot added a comment.Mar 26 2015, 11:38 AM

Change 199812 merged by jenkins-bot:
Fixes to the page action tutorial

https://gerrit.wikimedia.org/r/199812

Jdlrobson mentioned this in rEMFR1a14c5729a5e: Fixes to the page action tutorial.Mar 26 2015, 11:39 AM
Diffusion mentioned this in rMEXT2522d8d7b5ed: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 26 2015, 11:39 AM
• bmansurov unsubscribed.Mar 26 2015, 6:22 PM
gerritbot added a comment.Mar 26 2015, 8:55 PM

Change 199795 abandoned by Robmoen:
In beta, watchstar loads late and is edit tut is positioned incorrectly

https://gerrit.wikimedia.org/r/199795

Jdlrobson closed this task as Resolved.Mar 26 2015, 10:32 PM
Diffusion mentioned this in rMEXT9ff9a5db611b: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Apr 1 2015, 11:04 AM
• rmoen mentioned this in rEGATd1ab1955bcf9: Article reader sees guidance about creating a collection.Apr 8 2015, 6:17 PM
• rmoen mentioned this in rEGAT277afc3c25c2: Prevent tutorial from showing if user clicks watchstar prior to load.
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL