Page MenuHomePhabricator

Create composer validate --no-check-publish job for MediaWiki extensions
Closed, ResolvedPublic

Description

We want to use composer.json to specify development dependencies (T90943), however those extensions don't necessarily want to be published as composer packages.

I submitted https://github.com/composer/composer/pull/3804 which has been merged upstream to add a --no-check-publish which still ensures the file has valid syntax, but doesn't require it to be valid to be published as a composer package ('name' and 'description').

We should create a 'php-composer-validate-package' job which checks the composer.json file is valid to be published as a composer package for repos that do want that. All other extensions would use 'php-composer-validate', which uses the --no-check-publish option.

We'll have to also update our composer to something that has my patch (or backport it?).

Event Timeline

Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Krinkle set Security to None.

Change 194364 had a related patch set uploaded (by Legoktm):
Update to dev-master#05e196893b1225898de280ef8f97d5f2be684e8f

https://gerrit.wikimedia.org/r/194364

Change 194364 merged by Legoktm:
Update to dev-master#05e196893b1225898de280ef8f97d5f2be684e8f

https://gerrit.wikimedia.org/r/194364

Change 194421 had a related patch set uploaded (by Legoktm):
Use --no-check-publish in php-composer-validate, create php-composer-validate-package

https://gerrit.wikimedia.org/r/194421

Change 194421 merged by jenkins-bot:
Use --no-check-publish in php-composer-validate, create php-composer-package-validate

https://gerrit.wikimedia.org/r/194421

Legoktm claimed this task.