Page MenuHomePhabricator

[Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line
Closed, ResolvedPublic8 Estimated Story Points

Description

Steps to reproduce:

1.Open a page with VE
2.Select a text and open link inspector'

Observed Result:
It opens in random positions , sometimes few lines above the text selected and sometimes below it

See the screenshots

Screen_Shot_2015-03-02_at_12.16.19_PM.png (484×1 px, 103 KB)

Screen_Shot_2015-03-02_at_12.26.48_PM.png (616×790 px, 123 KB)

Event Timeline

Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Jdforrester-WMF renamed this task from [Regression pre-wmf20]Link inspector opening in wrong position to [Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line.Mar 3 2015, 6:28 PM
Jdforrester-WMF assigned this task to TrevorParscal.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set Security to None.

Change 194227 had a related patch set uploaded (by Esanders):
Only store linear selections as last context position

https://gerrit.wikimedia.org/r/194227

Change 194227 merged by jenkins-bot:
Only store selections which yield a valid context position

https://gerrit.wikimedia.org/r/194227

Change 194240 had a related patch set uploaded (by Esanders):
Fix desktop context positioning (again)

https://gerrit.wikimedia.org/r/194240

Change 194240 merged by jenkins-bot:
Fix desktop context positioning (again)

https://gerrit.wikimedia.org/r/194240

Change 194322 had a related patch set uploaded (by Esanders):
Use the inspector's previousSelection for context positioning

https://gerrit.wikimedia.org/r/194322

Change 194322 merged by jenkins-bot:
Use the inspector's previousSelection for context positioning

https://gerrit.wikimedia.org/r/194322