Page MenuHomePhabricator

Initial render of citations' (templates'?) context item provides links without target="_blank"
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:
1.Open a page with VE
2.Go to Cite>Website
3.Insert a URL such as "http://www.facebook.com"
4.Click on "Insert"
5.As soon as the context menu appears, click on the URL you just added

Observed Result:
It asks user whether to leave the page and attempts to open the URL in the same page instead of opening it in a new tab.
It happens only the first time, if you try clicking on the URL next time from context menu, it opens it on a new tab straight.

Screen_Shot_2015-03-02_at_12.51.14_PM.png (595×1 px, 349 KB)

Event Timeline

Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Jdforrester-WMF renamed this task from After adding a Cite web , when the context menu appears for the first time, clicking on the URL tries to leave the VE and open the URL in the same page instead of opening it in a new tab to Initial render of citations' (templates'?) context item provides links without target="_blank".Mar 3 2015, 6:34 PM
Jdforrester-WMF assigned this task to TrevorParscal.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.

Change 197987 had a related patch set uploaded (by Trevor Parscal):
[BREAKING CHANGE] Emit rerender for dead nodes

https://gerrit.wikimedia.org/r/197987

Change 197987 merged by jenkins-bot:
[BREAKING CHANGE] Emit rerender for dead nodes

https://gerrit.wikimedia.org/r/197987

Change 197988 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (5d5f8a4)

https://gerrit.wikimedia.org/r/197988

Change 197988 merged by jenkins-bot:
Update VE core submodule to master (5d5f8a4)

https://gerrit.wikimedia.org/r/197988