Page MenuHomePhabricator
Create Task
Maniphest T91317

Hovercards: doesn't show popup for [[Special:MyLanguage/Some page]] links on mw.org
Closed, DuplicatePublic
Actions

Description

Lots of links on mw.org are of the form [[ Special:MyLanguage/Some page ]] for i18n.

Hovercards doesn't show a popup for these. It makes its API request, but gets back e.g.

"pages": {
    "-1": {
        "ns": -1,
        "title": "Special:MyLanguage/Data and developer hub",
        "special": ""
    }
}

instead of useful information.

Either the Popups extension or the API query needs to "push through" Special:MyLanguage HTTP/1.1 302 forced.302 to the page in the user's language. FWIW Popups' API request specifies redirects=true.

This Sandbox edit shows the problem

Related Objects

Event Timeline

• Spage created this task.Mar 2 2015, 9:45 PM
• Spage raised the priority of this task from to Needs Triage.
• Spage updated the task description. (Show Details)
• Spage added projects: Page-Previews, MediaWiki-Action-API.
• Spage subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2015, 9:45 PM
Anomie subscribed.Mar 2 2015, 10:23 PM

The "push through" would probably apply to all RedirectSpecialPage subclasses when redirects=true. The annoying part being having to go through the list of special pages and find which ones are.

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.Mar 2 2015, 10:24 PM
Se4598 subscribed.Mar 2 2015, 10:55 PM
In T91317#1080115, @Anomie wrote:

The "push through" would probably apply to all RedirectSpecialPage subclasses when redirects=true. The annoying part being having to go through the list of special pages and find which ones are.

by the inheritance tree of RedirectSpecialPage that are for core: https://doc.wikimedia.org/mediawiki-core/master/php/html/classRedirectSpecialPage__inherit__graph.png

Ricordisamoa subscribed.Mar 3 2015, 6:54 AM
Anomie added a comment.EditedMar 3 2015, 7:54 PM
In T91317#1080277, @Se4598 wrote:

by the inheritance tree of RedirectSpecialPage that are for core: https://doc.wikimedia.org/mediawiki-core/master/php/html/classRedirectSpecialPage__inherit__graph.png

I think you misunderstood. The problem isn't in identifying that a particular special page is a subclass of RedirectSpecialPage, instanceof or is_subclass_of() handles that fine.

The problem is that the API code having a possibly-large list of special page titles would need to fetch the class implementing each one and check each one individually, which could turn out to be slow. And Gerrit change 152755 made it so we'd have to instantiate each special page, which would be even slower.

And we would have to consider what to do if the target of the RedirectSpecialPage is itself a redirect.

Anomie moved this task from Needs Code to Needs details or plan on the MediaWiki-Action-API board.Mar 3 2015, 7:54 PM
Jdlrobson triaged this task as Lowest priority.Sep 23 2015, 6:59 PM
Jdlrobson subscribed.

Isn't this fixed? Hovercards should not run on special pages and in your sandbox when I hover over the link nothing happens as expected.

I don't think investing time in making them work cross language is a worthy investment at this time (if that's what's being asked for we should convert this bug into an epic)

Ricordisamoa added a comment.Sep 24 2015, 6:44 PM
In T91317#1667361, @Jdlrobson wrote:

Isn't this fixed? Hovercards should not run on special pages and in your sandbox when I hover over the link nothing happens as expected.

This task is precisely about making Hovercards follow RedirectSpecialPages in addition to 'standard' redirects. Popups are otherwise quite useless on mediawiki.org.

MBinder_WMF added a project: Web-Team-Backlog-Archived.May 17 2016, 6:34 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Jul 4 2016, 7:24 PM
jeblad subscribed.Jan 23 2017, 7:19 PM

Note also T145541: Make Hovercards work with Special:MyLanguage links

jeblad mentioned this in T136480: Help pages and hovercards.Jan 23 2017, 7:19 PM
Jdlrobson closed this task as a duplicate of T145541: Make Hovercards work with Special:MyLanguage links.Feb 16 2017, 7:18 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits