JS errors in Firefox 16-21 due to missing crypto.getRandomValues()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Mar 3 2015, 8:59 AM

Description

Since T78449 generateRandomSessionId tries to use crypto.getRandomValues(), but it tests only the existence of window.crypto. At least in Firefox window.crypto exists longer (as non-standard implementation, at least since FF16) than crypto.getRandomValues() (starting with FF21). The implementation for generateRandomSessionId should check not only window.crypto, but also crypto.getRandomValues before calling it to avoid this error, even though this only affects old browsers.

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.user: Check crypto.getRandomValues before use	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rMW9ef33b971d33: mediawiki.user: Check crypto.getRandomValues before use
Mentioned Here: T78449: mw.user.generateRandomSessionId not so random

Event Timeline

Schnark created this task.Mar 3 2015, 8:59 AM

Schnark raised the priority of this task from to Needs Triage.

Schnark updated the task description. (Show Details)

Schnark added projects: JavaScript, MediaWiki-General.

Schnark subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2015, 8:59 AM

Aklapper renamed this task from JS errors in old Firefox due to missing crypto.getRandomValues() to JS errors in Firefox 16-21 due to missing crypto.getRandomValues().Mar 3 2015, 9:07 AM

Aklapper triaged this task as Lowest priority.

Aklapper added a project: good first task.

Aklapper set Security to None.

Krinkle subscribed.Mar 3 2015, 6:16 PM

Change 194156 had a related patch set uploaded (by Umherirrender):
Check crypto.getRandomValues in mw.user.js before use

https://gerrit.wikimedia.org/r/194156

gerritbot added a project: Patch-For-Review.Mar 3 2015, 6:24 PM

Umherirrender claimed this task.Mar 3 2015, 6:24 PM

matmarex closed this task as Resolved.Mar 3 2015, 10:19 PM

matmarex subscribed.

Change 194156 merged by jenkins-bot:
mediawiki.user: Check crypto.getRandomValues before use