Page MenuHomePhabricator

Jenkins qunit builds fail for many ContentTranslation patches and complain about EventLogging
Closed, DuplicatePublic

Description

Jenkins qunit builds fail for many ContentTranslation patches and complain about EventLogging

For example:

This is a blocker for development, so it's high priority.

Event Timeline

Amire80 raised the priority of this task from to High.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, hashar.

There are many things in the log and I am not sure which things are relevant and which are not:

09:24:17 curl: (23) Failed writing body (3721 != 16003)
Harmless?

09:24:42 Testing http://localhost:9412/jenkins-mwext-ContentTranslation-qunit-1435/index.php?title=Special:JavaScriptTest/qunit .........................................................................................................................................................F........................Exception thrown by test.module1
09:24:42 Error: expected Error: expected
09:24:45 ................................................................................................................F
09:24:45 >> mediawiki.jqueryMsg - Match PHP parser
09:24:45 >> Message: SyntaxError: Parse error
09:24:45 >> Actual: null
09:24:45 >> Expected: undefined
09:24:45 >> http://localhost:9412/jenkins-mwext-ContentTranslation-qunit-1435/load.php?debug=false&lang=en&modules=ext.uls.buttons%2Cdisplaysettings%2Cinputsettings%2Clanguagesettings&skin=fallback&version=20150303T092417Z&*:38
09:24:45 
09:24:45 >> mediawiki.jqueryMsg - Match PHP parser
09:24:45 >> Message: Expected 50 assertions, but 51 were run
09:24:45 >> Actual: null
09:24:45 >> Expected: undefined

Is this the actual error? I'm unable to reproduce locally.

09:24:45 >> ext.eventLogging: isInstanceOf() - global failure
09:24:45 >> Message: SyntaxError: Parse error
09:24:45 >> Actual: null
09:24:45 >> Expected: undefined
09:24:45 >> http://localhost:9412/jenkins-mwext-ContentTranslation-qunit-1435/load.php?debug=false&lang=en&modules=ext.eventLogging.subscriber%7Cext.uls.pt%7Cjquery.suggestions%7Cmediawiki.hidpi%2CsearchSuggest&skin=fallback&version=20150303T092417Z&*:21
09:24:45 
09:24:45 >> ext.eventLogging: isInstanceOf() - global failure
09:24:45 >> Message: Expected number of assertions to be defined, but expect() was not called.
09:24:45 >> Actual: null
09:24:45 >> Expected: undefined

Second error? Caused by above or not?

09:24:45 Warning: 4/1816 assertions failed (18760ms) Use --force to continue.
09:24:45 
09:24:45 Aborted due to warnings.

The MediaWiki logs are capture for each builds and attached to the build result. https://integration.wikimedia.org/ci/job/mwext-ContentTranslation-qunit/1432/ , compared to the previous passing build 1431, the mw-error.log file is bigger and there is a mw-exception.log file:

2015-03-03 04:48:49 integration-slave1001 my_wiki: [115b7dc6] /jenkins-mwext-ContentTranslation-qunit-1432/load.php?debug=false&lang=en&modules=ext.eventLogging.subscriber%7Cext.uls.pt%7Cjquery.suggestions%7Cmediawiki.hidpi%2CsearchSuggest&skin=fallback&version=20150303T044842Z&*   DBUnexpectedError from line 3669 of src/includes/db/Database.php: Attempted to commit transaction while atomic sections are still open
#0 src/includes/db/LoadBalancer.php(979): DatabaseBase->commit('LoadBalancer::c...', 'flush')
#1 [internal function]: LoadBalancer->commitMasterChanges()
#2 src/includes/db/LBFactory.php(176): call_user_func_array(Array, Array)
#3 [internal function]: {closure}(Object(LoadBalancer), 'commitMasterCha...', Array)
#4 src/includes/db/LBFactory.php(321): call_user_func_array(Object(Closure), Array)
#5 src/includes/db/LBFactory.php(177): LBFactorySimple->forEachLB(Object(Closure), Array)
#6 src/includes/db/LBFactory.php(184): LBFactory->forEachLBCallMethod('commitMasterCha...')
#7 src/includes/db/LBFactory.php(336): LBFactory->commitMasterChanges()
#8 src/load.php(50): LBFactorySimple->shutdown()
#9 {main}
2015-03-03 04:48:52 integration-slave1001 my_wiki: [e71ca201] /jenkins-mwext-ContentTranslation-qunit-1432/load.php?debug=false&lang=en&modules=ext.uls.buttons%2Cdisplaysettings%2Cinputsettings%2Clanguagesettings&skin=fallback&version=20150303T044842Z&*   DBUnexpectedError from line 3669 of src/includes/db/Database.php: Attempted to commit transaction while atomic sections are still open
#0 src/includes/db/LoadBalancer.php(979): DatabaseBase->commit('LoadBalancer::c...', 'flush')
#1 [internal function]: LoadBalancer->commitMasterChanges()
#2 src/includes/db/LBFactory.php(176): call_user_func_array(Array, Array)
#3 [internal function]: {closure}(Object(LoadBalancer), 'commitMasterCha...', Array)
#4 src/includes/db/LBFactory.php(321): call_user_func_array(Object(Closure), Array)
#5 src/includes/db/LBFactory.php(177): LBFactorySimple->forEachLB(Object(Closure), Array)
#6 src/includes/db/LBFactory.php(184): LBFactory->forEachLBCallMethod('commitMasterCha...')
#7 src/includes/db/LBFactory.php(336): LBFactory->commitMasterChanges()
#8 src/load.php(50): LBFactorySimple->shutdown()
#9 {main}

Ie Attempted to commit transaction while atomic sections are still open no clue what it is the cause. Maybe it is caused by the mediawiki/core change https://gerrit.wikimedia.org/r/#/c/193261/ ?

In short: please attempt to reproduce locally with the tip of the master branches of your extension / core and vendor. Then trie with the mediawiki/core commit before 80a3a30d6a90b21f68cca4dfe5b3623cb9e5e7fc and see if it works.