Page MenuHomePhabricator
Create Task
Maniphest T91408

Values in qualifiers and references not linked by AuthorityControl Gadget
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
_createQualifiersListview in statementview not just in edit modemediawiki/extensions/Wikibasemaster+6 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Mar 3 2015, 4:38 PM
Tobi_WMDE_SW raised the priority of this task from to High.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW added a project: Wikidata.
Tobi_WMDE_SW added subscribers: Tobi_WMDE_SW, aude.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2015, 4:38 PM
Tobi_WMDE_SW mentioned this in T87858: Adjust AuthorityControl Gadget to snakview name changes.Mar 3 2015, 4:38 PM
gerritbot subscribed.Mar 3 2015, 4:39 PM

Change 193565 had a related patch set uploaded (by Tobias Gritschacher):
_createQualifiersListview in statementview not just in edit mode

https://gerrit.wikimedia.org/r/193565

gerritbot added a project: Patch-For-Review.Mar 3 2015, 4:39 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 4 2015, 3:09 PM
Tobi_WMDE_SW added a subtask: T92378: Investigate how to proper fix AC Gadget for qualifiers and references.Mar 11 2015, 1:15 PM
gerritbot added a comment.Mar 19 2015, 9:09 AM

Change 193565 abandoned by Aude:
_createQualifiersListview in statementview not just in edit mode

Reason:
i don't think we want to do this and need to fix authority control some other way

https://gerrit.wikimedia.org/r/193565

aude removed a project: Patch-For-Review.EditedMar 19 2015, 11:44 AM
aude set Security to None.

https://gerrit.wikimedia.org/r/#/c/189018/ is what has caused the gadget to completely break again. gadget needs to be adjusted for that.

Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-24.Mar 24 2015, 1:16 PM
Tobi_WMDE_SW assigned this task to aude.Mar 24 2015, 1:48 PM
Tobi_WMDE_SW moved this task from Backlog to Doing on the § Wikidata-Sprint-2015-03-24 board.
aude added a comment.Mar 24 2015, 4:08 PM

https://www.wikidata.org/w/index.php?title=User%3AAude%2Fauthority.js&diff=206460066&oldid=200607234 are the changes needed when we deploy new code

linking identifiers in references and qualifiers no longer depends on those js widgets being initialized, which no longer will be the case on page view. this works okay for any values of a string type, but not yet for coordinates.

updated the gadget on test.wikidata, as well as beta:

https://test.wikidata.org/wiki/Q1024

https://test.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js

various other issues still remain and have created T93762 tracking bug for those.

aude mentioned this in T93763: [Bug] Coordinates in references and qualifiers should be linked in authority control gadget.Mar 24 2015, 4:10 PM
aude added a parent task: T93762: Authority Control gadget tracking bug.
Tobi_WMDE_SW closed this task as Resolved.Mar 25 2015, 8:44 AM
Tobi_WMDE_SW moved this task from Doing to Done on the § Wikidata-Sprint-2015-03-24 board.
Tobi_WMDE_SW closed subtask T92378: Investigate how to proper fix AC Gadget for qualifiers and references as Resolved.
Ricordisamoa added a project: Wikidata-Gadgets.Aug 23 2015, 2:15 PM
Ricordisamoa subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits