Page MenuHomePhabricator

Tokenizer incorrectly parses a "!!" inside a HTML <td> cell as a <th>
Closed, ResolvedPublic

Description

In this example above, "c" is parsed as a <th>.. </th> which is broken obviously .. "" in the middle of a line should not parse to a header if there is no "!"-based th at the start of that line.

{|
!a
<tr><td>b!!c</td></tr>
|}

Causes RT diffs here: http://parsoid-lb.eqiad.wikimedia.org/_rt/kowiki/%EB%A7%88%EC%9D%B4%ED%8B%B0_%EB%AA%A8

Event Timeline

ssastry created this task.Mar 3 2015, 5:07 PM
ssastry raised the priority of this task from to Normal.
ssastry updated the task description. (Show Details)
ssastry added a subscriber: ssastry.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2015, 5:07 PM
ssastry renamed this task from Tokenizer incorrectly parses a "!!c" inside a HTML <td> cell as a <th> to Tokenizer incorrectly parses a "!!" inside a HTML <td> cell as a <th>.Mar 3 2015, 5:13 PM
ssastry set Security to None.
Arlolra claimed this task.Jun 4 2015, 7:33 PM

Same with:

{|
|a
<tr><th>b||c</th></tr>
|}

Change 216015 had a related patch set uploaded (by Arlolra):
"!!" should only break "!"-based <th> on the line they start

https://gerrit.wikimedia.org/r/216015

Change 216015 merged by jenkins-bot:
"!!" should only break "!"-based <th> on the line they start

https://gerrit.wikimedia.org/r/216015