Page MenuHomePhabricator

Compute initial toolbar offsets by inspecting div#content
Open, MediumPublic

Description

When VE is initialized, there is a call to ve.ui.Toolbar#calculateOffset, to calculate the left and right offsets of the toolbar. But the offsets should be the same as div#content, so we could compute the offsets earlier, when we're still waiting for the API response. Ed thinks that this is sensible, but he points out that there is a possible edge case to account for, when switching to VE changes whether or not you have a scroll bar.

Event Timeline

ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added a project: VisualEditor-Performance.
ori subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF set Security to None.
Stesmo subscribed.

Accidentally dragged this item into another workboard... Hopefully didn't mess up everything too much here.