webm; codecs="vp8, vorbis"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Mar 3 2015, 7:10 PM

Description

Consider https://commons.wikimedia.org/wiki/File:Diamond_Trust_of_London_-_Kickstarter.webm

There is the original file + a low quality ogg transcode. The original file should be selected on firefox/chrome as best transcode (And on android it should be the only choice).

However, the original version is detected as having mime video/webm; codecs="vorbis, vp8". TMH does a string comparision in mw.MediaPlayer.js (mw.MediaPlayer.prototype.supportsMimeType) to video/webm; codecs="vp8, vorbis" and determines they are not equal, and refuses to select the original asset to play, resulting in the ogg file being used on firefox, and the not supported msg on android native browser.

Original report https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=151985029#Video_quality_fixed_incorrectly

Details

Subject	Repo	Branch	Lines +/-
Make mime type check more robust	mediawiki/extensions/TimedMediaHandler	master	+18 -2
Fix playback of WebM source files	mediawiki/extensions/TimedMediaHandler	REL1_25	+10 -10
Fix playback of WebM source files	mediawiki/extensions/TimedMediaHandler	master	+10 -10

Customize query in gerrit

Related Objects

Mentioned In: T109150: TimedMediaHandler videos will not work on MediaWiki 1.25
T98694: Enable 2160p (aka 4k) video support in TMH
rETMH3328ea0f44f0: Fix playback of WebM source files
rMEXTe2f78c2c416e: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler…

Event Timeline

Bawolff created this task.Mar 3 2015, 7:10 PM

Bawolff raised the priority of this task from to Needs Triage.

Bawolff updated the task description. (Show Details)

Bawolff added projects: Multimedia, TimedMediaHandler.

Bawolff added subscribers: Bawolff, • Gilles.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2015, 7:10 PM

• brion subscribed.Mar 3 2015, 8:21 PM

Change 194918 had a related patch set uploaded (by Brian Wolff):
Make mime type check more robust

https://gerrit.wikimedia.org/r/194918

gerritbot added a project: Patch-For-Review.Mar 6 2015, 6:44 PM

TheDJ moved this task from To sort to Doing on the TimedMediaHandler board.Mar 21 2015, 1:42 PM

Change 231309 had a related patch set uploaded (by Brion VIBBER):
Fix playback of WebM source files

https://gerrit.wikimedia.org/r/231309

Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 13 2015, 5:11 PM

Change 231309 merged by jenkins-bot:
Fix playback of WebM source files

https://gerrit.wikimedia.org/r/231309

Diffusion mentioned this in rMEXTe2f78c2c416e: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler….Aug 14 2015, 12:03 PM

• brion mentioned this in rETMH3328ea0f44f0: Fix playback of WebM source files.Aug 14 2015, 12:03 PM

• Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 14 2015, 1:00 PM

• brion mentioned this in T98694: Enable 2160p (aka 4k) video support in TMH.Aug 15 2015, 8:54 AM

• brion mentioned this in T109150: TimedMediaHandler videos will not work on MediaWiki 1.25.Aug 21 2015, 8:44 PM

This change went live; confirmed fixed on original reported file.

• brion merged a task: T109150: TimedMediaHandler videos will not work on MediaWiki 1.25.Aug 28 2015, 5:43 PM

• brion added a subscriber: ComputeVictory.

Jdforrester-WMF triaged this task as Medium priority.Sep 15 2015, 8:16 PM

Jdforrester-WMF moved this task from Untriaged to Done on the Multimedia board.

Jdforrester-WMF set Security to None.

Change 244826 had a related patch set uploaded (by Paladox):
Fix playback of WebM source files

https://gerrit.wikimedia.org/r/244826

Change 244826 merged by jenkins-bot:
Fix playback of WebM source files

https://gerrit.wikimedia.org/r/244826

TheDJ moved this task from Doing to Done on the TimedMediaHandler board.Oct 20 2015, 11:52 AM

Change 194918 abandoned by Brian Wolff:
Make mime type check more robust

Reason:
No longer caring about this patch