| • Spage | |
| Mar 3 2015, 8:13 PM |
| F54178: 2015-03-03_Phabricator_Send_Message_failure | |
| Mar 3 2015, 8:13 PM |
Result: I got an error alert, see F54178
Access Denied: Restricted Application
You do not have permission to view this object.
Users with the "Can View" capability:
- This object has a custom policy controlling who can take this action.
Chasemp on IRC commented " not sure need to ask upstream if intentional change or not. it was hidden tho before"
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T91438 [Send Message] button on person page is shown to users without permission, showing error message | |||
| Resolved | Qgil | T91392 Enable Conpherence for all Wikimedia Phabricator users |
After looking at this I think it is expected behavior. We don't have the app uninstalled, just permissioned. It is standard for that to leave the UI object but throw a warning. We can uninstall or move forward with Conpherence or live with disallowed users getting an error I think.
Until now upstream has accepted our reports referring to links that shouldn't be seen by the people that doesn't have the permissions to do anything with them. I think we can keep this task, and I expect whoever reports it will make a good use of their time.
Not against asking upstream or whatnot, but I thought the issue of hidding UI items was related to uninstalled apps only. An installed but policy restricted app I can't remember the same reasoning.
This is likely obsolete because the "Send Message" action was removed a long time ago. I don't have any current plans to restore it.
This was (usually) expected behavior: we generally treat "Application is installed, but user can't use it" like a permissions issue, not like "Uninstall". For example, when you visit /T123, you get a 404 if Maniphest has been uninstalled. You get a policy dialog if Maniphest is installed but you can't use the application, or you can use the application but you can't see T123.
Practically, I think we've often just removed actions that have weird behavior here, since they're often not great actions anyway (both "Create New Project" in T631 and "Send Message" here were simply removed).