| matmarex | |
| Mar 4 2015, 5:32 PM |
| F82975: pasted_file | |
| Mar 11 2015, 8:38 PM |
| F55141: pasted_file | |
| Mar 4 2015, 5:32 PM |
| F55144: pasted_file | |
| Mar 4 2015, 5:32 PM |
Icon-only framed buttons are asymmetrical. Using Opera 28 on Windows 7.
8x zoom:
I haven't noticed this before, so I conjecture that this is a regression. Might be caused by @Esanders's sizing changes done to support background-size: contain – we now have a ton of fractional measurements like width: 1.875em; which might be getting inconsistently truncated.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Revert "Button styles between OOJS and MW" | oojs/ui | master | +13 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | matmarex | T147692 Should OOUI Widgets apply `box-sizing: border-box` as general rule? | |||
| Resolved | Volker_E | T146962 ButtonWidgets should use `box-sizing: border-box` | |||
| Resolved | Volker_E | T91523 Icon-only framed buttons are asymmetrical by one pixel |
Way worse now in MediaWiki theme after https://gerrit.wikimedia.org/r/#/c/194753/ was merged.
Change 200747 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Button styles between OOJS and MW"
This is not fixed. Please ignore everything that happened on this bug since the initial description, that was all actually unrelated and I tagged it against this mistakenly.
That's also dependent on the absolute positioned icon. We can more easily do away with this when https://gerrit.wikimedia.org/r/#/c/313940/ is merged.
This has finally been resolved! Hooray. Probably in the course of https://gerrit.wikimedia.org/r/#/c/346216/