Page MenuHomePhabricator
Create Task
Maniphest T91584

MediaWiki OAuth panel could be more clear in Phabricator
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • go to settings/external accounts
  • click on "mediawiki"
  • click through the OAuth permission screen on mw.org

phabricator-oauth.png (231×543 px, 28 KB)

phabricator-oauth-2.png (284×1 px, 30 KB)

  • the bold text is phrased in a confusing way: I can't tell if "mediawiki" is the username or the site name or the provider name
  • account ID instead of account name
  • the link is unreadable and completely broken (clicking it gives you a "Bad Request" error), probably URL encoded twice
  • also, why not use nice URLs?

All in all, I have no idea whether linking the account was successful; if I had a username with lots of non-ASCII chars, I couldn't even tell if it's indeed my account that's about to be linked.

Related Objects

Event Timeline

Tgr created this task.Mar 4 2015, 10:55 PM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: Phabricator.
Tgr subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2015, 10:55 PM
Tgr added a parent task: T86869: Support a nice sso experience with MediaWiki's OAuth.Mar 4 2015, 10:55 PM
Aklapper added a comment.Mar 5 2015, 9:22 AM
  • click on "mediawiki"

Ah, I assume that you only had your LDAP account configured in Phab, that's why I could not find it. :)

  • the bold text is phrased in a confusing way: I can't tell if "mediawiki" is the username or the site name or the provider name

I agree, but most people have managed so far. :)

  • account ID instead of account name

I'm afraid that is an upstream implementation detail.

  • the link is unreadable and completely broken (clicking it gives you a "Bad Request" error), probably URL encoded twice

That's T574

  • also, why not use nice URLs?

What are nice URLs?

Aklapper renamed this task from MediaWiki OAuth panel looks broken in Phabricator to MediaWiki OAuth panel could be more clear in Phabricator.Mar 5 2015, 9:22 AM
Aklapper triaged this task as Lowest priority.
Aklapper set Security to None.
Tgr added a comment.Mar 6 2015, 2:00 AM
In T91584#1091605, @Aklapper wrote:

What are nice URLs?

mediawiki.org/wiki/...

bd808 removed a parent task: T86869: Support a nice sso experience with MediaWiki's OAuth.Mar 30 2015, 7:40 PM
Aklapper changed the task status from Open to Stalled.Aug 1 2018, 8:57 AM

As written in T542 and T87758 some improvements have taken place, at least on https://phabricator.wikimedia.org/settings/panel/external/ .
Could you retest, please?

Tgr added a comment.Aug 1 2018, 10:18 AM

It's a lot better. Could still be improved by using nice URLs and user name instead of user ID. (And "mediawiki" User / "ldap" User could be MediaWiki user / LDAP user (or even Wikimedia user) but that's just nitpicking.)

Aklapper changed the task status from Stalled to Open.Aug 1 2018, 10:23 AM
Aklapper moved this task from To Triage to Needs code (in Phab or bot) on the Phabricator board.Aug 29 2018, 6:30 PM
Aklapper merged a task: T231745: Unnecessary port's two points in linked MW account link in External Accounts.Sep 1 2019, 12:53 PM
Aklapper added subscribers: Framawiki, • mmodell.
Aklapper closed this task as Resolved.Mar 26 2024, 2:57 AM

I think this is sufficiently clear nowadays - everything mentioned in the original task description seems to have been fixed in the meantime.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits