⚓ T91696 Proper collection sharing format/content

Subject	Author	Repo	Branch	Lines +/-
Include collection image in html for sharing	Jdlrobson	mediawiki/extensions/Gather	master	+19 -6
Add ogimage tag	Jdlrobson	mediawiki/extensions/Gather	master	+64 -6
Fix meta tags for collections	Jdlrobson	mediawiki/extensions/Gather	master	+10 -1

• JKatzWMF created this task.Mar 5 2015, 9:01 PM

• JKatzWMF raised the priority of this task from to Needs Triage.

• JKatzWMF updated the task description. (Show Details)

• JKatzWMF added a project: Gather.

• JKatzWMF added subscribers: • JKatzWMF, Jdlrobson, • MSyed, • Moushira.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2015, 9:01 PM

• JKatzWMF moved this task from Needs triage to This Sprint on the Gather board.Mar 5 2015, 9:07 PM

• JKatzWMF moved this task from This Sprint to Could have on the Gather board.

Jdlrobson added a project: Gather Sprint Diplodocus.Mar 19 2015, 5:52 PM

Jdlrobson set Security to None.

Jdlrobson edited projects, added: Gather Sprint Enwiki; removed: Gather Sprint Diplodocus.

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited a custom field.

Jdlrobson merged a task: T93226: When sharing on web ensure illustration for share is page image of collection.

Jdlrobson moved this task from Could have to In sprint on the Gather board.Mar 19 2015, 5:56 PM

Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Enwiki board.Mar 30 2015, 5:50 PM

Take a look at microformats.org

Jdlrobson claimed this task.Mar 30 2015, 8:01 PM

Jdlrobson moved this task from Ready for dev to In development on the Gather Sprint Enwiki board.

Change 200745 had a related patch set uploaded (by Jdlrobson):
Fix meta tags for collections

https://gerrit.wikimedia.org/r/200745

gerritbot added a project: Patch-For-Review.Mar 30 2015, 9:16 PM

Patch covers description and title. To get a nice image showing up though we will have to do one of two things

Add the image for collection at the top of the page. It can be hidden if necessary.
Switch from our use of background images to actual images - position images inside a div with overflow hidden to control positioning.
Use og tags (I'd prefer not to)

You can test here https://developers.facebook.com/tools/debug/og/object/

I'm leaning towards 2

Change 200754 had a related patch set uploaded (by Jdlrobson):
Use images rather than background-image for page images in collection

https://gerrit.wikimedia.org/r/200754

Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Enwiki board.Mar 30 2015, 9:34 PM

phuedx subscribed.Mar 31 2015, 8:28 AM

Jdlrobson merged a task: T94247: Meta tags for sharing lists.Apr 1 2015, 5:02 PM

Jdlrobson added a subscriber: • Jhernandez.

Change 200745 merged by jenkins-bot:
Fix meta tags for collections

https://gerrit.wikimedia.org/r/200745

Jdlrobson mentioned this in rMEXT20cb45875176: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Apr 1 2015, 6:27 PM

@Jhernandez since you know the most about the image handling feel free to take over ownership of this bug and look at https://gerrit.wikimedia.org/r/200754

Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Enwiki board.Apr 1 2015, 9:38 PM

• Jhernandez claimed this task.Apr 3 2015, 10:11 AM

Plz review

(PS3) Jhernandez: Include collection image in html for sharing [extensions/Gather] - https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: Jdlrobson)

Workz fine with facebook, but a pain to test because of what I've commented on the commit message. This just adds a hidden image in the html for the scrappers to pick up.

• Jhernandez moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Enwiki board.Apr 3 2015, 11:15 AM

So I did a bit more research and hidden image only works for Facebook... There is an interesting thread on wikitech about exposing og:image meta tag ...