Phabricator now tells us; this is just spam.
- Mentioned In
- T93331: gerritbot doesnt escape sequences from commitmsg
- Mentioned Here
- rEFLW001bd62e578b: Add i18n for flow-create-board right
rOPUPd72a449559e4: add ferm service for poolcounterd
rOPUP94ba37e61e50: have base::firewall on codfw poolcounters
rOPUP252847e946dc: make twentyafterfour a phabricator-admin
rPWBCad9094604c45: i18n.input prompt fallback
T93192: Old help module raises an exception
T68897: ImportError when git submodule i18n not initialised
Phabricator only tells you about merged commits that mention a task somewhere in the commit message.
But at some point we decided that we only care to leave comments when the task has been mentioned it the
commit message's last paragraph via Bug: $TASK_ID.
So gerritbot's notifications differ from the phabricator notifications.
Changing and telling gerritbot to no longer comment on merges is simple.
Hence ... is there some rough consensus that we want to change?
(I for one care care way more about commits that really address a task (i.e.: Bug: $TASK_ID in last paragraph) than those that just mention a task somewhere)
I believe this restriction was put in place because the gerritbot (at the time for Bugzilla) did more than just leave a comment. It also changed the bug status. This is still the case in the incarnation for Phabricator as well (it adds Patch-For-Review). Mentioning that it was mentioned in itself seems valuable and either way is unavailable in Phabricator as that its nature (which I think is a good thing to have).
Indicating whether a commit fixes a bug is done in Phabricator with the phrase Fixes T123 (generally as last line of the commit message body before the meta footer). Which even auto-closes the task when the commit is merged (just like on GitHub).
auto-closing a task on merge assumes that all intended fixes are actually working (without verifying them). in reality they often need follow-ups and we should have the habit to confirm fixes after merging. it's like in Bugzilla you have "resolved" but it's not the last workflow step, it's only somebody claiming resolved and the last step is actually "verified".
They should be right below the gerritbot comment.
@Dzahn mentioned this in rOPUP252847e946dc: make twentyafterfour a phabricator-admin
@Dzahn mentioned this in rOPUPd72a449559e4: add ferm service for poolcounterd
@Dzahn mentioned this in rOPUP94ba37e61e50: have base::firewall on codfw poolcounters
Mattflaschen closed this task as "Resolved" by committing rEFLW001bd62e578b: Add i18n for flow-create-board right
Ok, thanks. But mentioning a bug in a commit message just means it got uploaded for review. The other interesting part is when or _if_ it actually gets merged. I think the bot messages are actually better. There is one comment for the initial upload and one when/if it gets merged (but not one for each new patch set in the same change because that would be too much) and i like that. "auto-resolve by committing" feels like it lacks verification as mentioned above.
Removing Continuous-Integration-Infrastructure since this is about the Gerritbot that relay Gerrit event to Phabricator. We have enough bugs as is.
That being said, I like the notification on tasks, that let me know something happened on that task and take action such as closing the task. Not all repos are in Diffusion nor do Diffusion always notify me of a patch.
@QChris mentioned gerrit bot only reports on tasks explicitly mentioned via a bug: Txxx field whereas Phabricator does it for any Txxx occurrence.
Seems to me there is no consensus to disable it. I am thus closing this task for now. One can reach out to more people to figure out a nice solution to reduce notification spam.