Page MenuHomePhabricator

Wikidata Query: Secure BlazeGraph's SPARQL: Investigate HistoryServiceFactory
Closed, ResolvedPublic

Description

HistoryServiceFactory looks to expose some history. I'm not sure if its safe or not.

Event Timeline

Manybubbles raised the priority of this task from to Medium.
Manybubbles updated the task description. (Show Details)

Not sure for public endpoint - some people would love the chance to look at the queries, but some people may be concerned for privacy reasons (aka "why did you look for nuclear stations within 10 mile radius of your location?").

For internal endpoints I guess we can allow everything and trust ourselves?

Indeed. I created the task because I saw the class when I was looking for
federated queries and didn't have time to read it but it looked like it
might cause us trouble.

This seems to be controlled by com.bigdata.rdf.store.AbstractTripleStore.historyService with default false. So unless we manually enable it (which we won't) it is fine.

Smalyshev claimed this task.

Also, judging from the fact that create() in HistoryServiceFactory right now just throws an exaception, I'm not sure it actually can return anything.

See also http://jira.blazegraph.com/browse/BLZG-149