Page MenuHomePhabricator

the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages
Open, MediumPublic

Description

If I go to https://m.mediawiki.org/wiki/Talk:Flow , I see "Last just now by an anonymous user".

This is wrong for a couple of reasons:

  • This message is supposed to appear only if the page was edited very recently (I believe that very recently means "less than 10 seconds). This page was not edited very recently as far as I can see.
  • If it does appear at all, then the word "edited" is supposed to appear there, like this: "Last edited just now by an anonymous user". It may have something to do with {{GENDER}}, because the message says "{{GENDER:$1|edited}}".

As I wrote, the message is not supposed to appear in the first place, so the gender parameter ($1) might be invalid, but it's still odd, because I would think that {{GENDER}} is supposed to return the first result ("edited") for an invalid parameter. @Nikerabbit, any thoughts?

Event Timeline

Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, Nikerabbit, EBernhardson.

Sidenote: in the MF beta, the "last edited" strapline has been moved to the
bottom of all pages.

Amire80 set Security to None.

This appears to be caused by that page having a revision ID of 0, though I'm not sure why that's the case.

In the SkinMinerva#getHistoryLink method we retrieve the timestamp for the revision ID using Revision::getTimestampFromId, which, when passed a revision ID of 0 looks like it'll simply return the current timestamp.

This appears to be caused by that page having a revision ID of 0, though I'm not sure why that's the case.

Me neither (there is generally a core revision representing boards), but it's something we need to fix (T92296: wgRevisionId is 0 for Flow pages).

Is there some way in core of marking a page as not really being a page... some kind of isPseudoPage function ?

@Mattflaschen: Once we have an answer for T92296, then we can work/not-work on this as necessary.