Page MenuHomePhabricator

Upload form: Hide license input if and only if `wpDestFile` points to an existing file description page
Open, MediumPublic

Description

Only if the wpForReUpload parameter is set, the license input is hidden. This is IMHO also wrong behaviour of the upload form. It should hide the license input if the wpDestFile parameter is set to something for which a file description page exists. And only then. The wpForReUpload parameter is good for suppressing warnings but that should be all it does.

Event Timeline

Rillke created this task.Mar 7 2015, 5:26 PM
Rillke claimed this task.
Rillke raised the priority of this task from to Needs Triage.
Rillke updated the task description. (Show Details)
Rillke added a project: MediaWiki-Uploading.
Rillke added a subscriber: Rillke.
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 7 2015, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Rillke triaged this task as Medium priority.Mar 7 2015, 5:26 PM
Rillke added a comment.Mar 7 2015, 5:33 PM

For previous discussion, c.f. I3ca93566728

Change 195230 had a related patch set uploaded (by Rillke):
Upload form: Show or hide form controls dependent on existence of destination

https://gerrit.wikimedia.org/r/195230

Tgr added a subscriber: Tgr.Mar 9 2015, 8:46 PM

Make sure the interface makes sense if someone does not realize they are uploading to an existing file name. A clumsy solution would be showing "You are about to upload a new version of an existing file. License selection has been disabled." in place of the selector.

Rillke set Security to None.
Steinsplitter moved this task from Incoming to Uploading on the Commons board.Mar 11 2015, 12:45 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:25 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 6:25 PM
Restricted Application added a subscriber: Poyekhali. · View Herald TranscriptJun 19 2016, 4:37 AM

@Rillke: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task?
If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

Rillke removed Rillke as the assignee of this task.Mar 1 2020, 6:57 PM