Page MenuHomePhabricator
Create Task
Maniphest T91912

API allpages does not return proofread property for all pages
Closed, ResolvedPublic
Actions

Description

The following query:
http://en.wikisource.org/w/api.php?inprop=protection&maxlag=5&gaplimit=500&generator=allpages&format=jsonfm&gapprefix=Love_among_the_chickens_%281909%29.djvu&prop=info|imageinfo|categoryinfo|proofread&gapnamespace=104&continue=&meta=userinfo&indexpageids=&action=query&iiprop=timestamp|user|comment|url|size|sha1|metadata&gapfrom=!&uiprop=blockinfo|hasmsg

from page /144 does not return proofread property:

...
"1642555": {
    "pageid": 1642555,
    "ns": 104,
    "title": "Page:Love among the chickens (1909).djvu/143",
    "contentmodel": "proofread-page",
    "pagelanguage": "en",
    "touched": "2014-11-13T03:17:12Z",
    "lastrevid": 4888277,
    "length": 943,
    "protection": [],
    "restrictiontypes": [
        "edit",
        "move"
    ],
    "proofread": {
        "quality": 4,
        "quality_text": "Validated"
    }
},
"1642557": {
    "pageid": 1642557,
    "ns": 104,
    "title": "Page:Love among the chickens (1909).djvu/144",
    "contentmodel": "proofread-page",
    "pagelanguage": "en",
    "touched": "2015-03-08T00:05:15Z",
    "lastrevid": 4888278,
    "length": 925,
    "protection": [],
    "restrictiontypes": [
        "edit",
        "move"
    ]
},
...

A shorter query does:
http://en.wikisource.org/w/api.php?inprop=protection&maxlag=5&gaplimit=500&generator=allpages&format=jsonfm&gapprefix=Love_among_the_chickens_%281909%29.djvu/14&prop=info|imageinfo|categoryinfo|proofread&gapnamespace=104&continue=&meta=userinfo&indexpageids=&action=query&iiprop=timestamp|user|comment|url|size|sha1|metadata&gapfrom=!&uiprop=blockinfo|hasmsg

...
"1642555": {
    "pageid": 1642555,
    "ns": 104,
    "title": "Page:Love among the chickens (1909).djvu/143",
    "contentmodel": "proofread-page",
    "pagelanguage": "en",
    "touched": "2014-11-13T03:17:12Z",
    "lastrevid": 4888277,
    "length": 943,
    "protection": [],
    "restrictiontypes": [
        "edit",
        "move"
    ],
    "proofread": {
        "quality": 4,
        "quality_text": "Validated"
    }
},
"1642557": {
    "pageid": 1642557,
    "ns": 104,
    "title": "Page:Love among the chickens (1909).djvu/144",
    "contentmodel": "proofread-page",
    "pagelanguage": "en",
    "touched": "2015-03-08T00:05:15Z",
    "lastrevid": 4888278,
    "length": 925,
    "protection": [],
    "restrictiontypes": [
        "edit",
        "move"
    ],
    "proofread": {
        "quality": 4,
        "quality_text": "Validated"
    }
   ...

Details

SubjectRepoBranchLines +/-
Makes api prop=proofread pass context to its subrequestmediawiki/extensions/ProofreadPagemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Mpaa created this task.Mar 8 2015, 12:12 AM
Mpaa raised the priority of this task from to Needs Triage.
Mpaa updated the task description. (Show Details)
Mpaa added projects: MediaWiki-Action-API, ProofreadPage.
Mpaa subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2015, 12:12 AM
Mpaa set Security to None.Mar 8 2015, 12:21 AM
Mpaa added a subscriber: Tpt.
Tpt added a comment.Mar 8 2015, 8:48 AM

The cause of the issue is that ProofreadPage does an internal API request to retrieve quality levels and, so, is affected by the default limit (50 I believe): https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FProofreadPage.git/d16b90fed6d709f4dff8c4ea9d5412ebcf9d8fbf/ApiQueryProofread.php#L57

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Mar 8 2015, 11:54 AM
Anomie subscribed.
In T91912#1098836, @Tpt wrote:

The cause of the issue is that ProofreadPage does an internal API request

Eeew.

Mpaa added a subscriber: jayvdb.Mar 8 2015, 10:24 PM
Aklapper triaged this task as Low priority.Mar 9 2015, 12:11 PM
Tpt moved this task from Backlog to Top priority on the ProofreadPage board.Mar 19 2015, 7:27 AM
Arjunaraoc subscribed.Apr 12 2015, 1:32 AM

Access Index page as it will provide proofread property for all pages.

gerritbot subscribed.Jul 4 2015, 7:58 PM

Change 222849 had a related patch set uploaded (by Tpt):
Makes api prop=proofread pass context to its subrequest

https://gerrit.wikimedia.org/r/222849

gerritbot added a project: Patch-For-Review.Jul 4 2015, 7:58 PM
gerritbot added a comment.Jul 7 2015, 1:47 AM

Change 222849 merged by jenkins-bot:
Makes api prop=proofread pass context to its subrequest

https://gerrit.wikimedia.org/r/222849

Diffusion mentioned this in rMEXTa1708bbc37b9: Updated mediawiki/extensions Project: mediawiki/extensions/ProofreadPage….Jul 7 2015, 1:48 AM
Tpt mentioned this in rEPRPea912c00a387: Makes api prop=proofread pass context to its subrequest.Jul 7 2015, 1:53 AM
• Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 7 2015, 2:00 AM
GOIII assigned this task to Tpt.Jul 11 2015, 8:02 AM
GOIII subscribed.

Rechecking with the initial query first reported:
http://en.wikisource.org/w/api.php?inprop=protection&maxlag=5&gaplimit=500&generator=allpages&format=jsonfm&gapprefix=Love_among_the_chickens_%281909%29.djvu&prop=info|imageinfo|categoryinfo|proofread&gapnamespace=104&continue=&meta=userinfo&indexpageids=&action=query&iiprop=timestamp|user|comment|url|size|sha1|metadata&gapfrom=!&uiprop=blockinfo|hasmsg

...does return proofread property past page /144. Closing

GOIII closed this task as Resolved.Jul 11 2015, 8:03 AM
Mpaa mentioned this in rPWBC65eff294c30a: Move setting of prop=proofread in Request._add_defaults().Sep 19 2015, 2:23 PM
GOIII moved this task from Top priority to Done: to deploy/check on the ProofreadPage board.Jun 12 2016, 4:00 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL