Page MenuHomePhabricator

mediawiki-extensions-hhvm should run for all covered extensions (eg. Flow)
Closed, ResolvedPublic

Description

In general, when extension A depends on extension B, and A runs the mediawiki-extensions-hhvm job but B doesn't, B could break something HHVM-specific without noticing, that then causes A's jobs to fail. This is what caused T91967: Flow doesn't run the HHVM tests, but Thanks and VE do.

In general I would argue that this situation shouldn't be allowed to exist: if A depends on B, either both or neither should run the HHVM tests.

Details

Related Gerrit Patches:

Event Timeline

Catrope created this task.Mar 9 2015, 1:26 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added subscribers: Catrope, Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2015, 1:26 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Mar 9 2015, 4:30 PM
Jdforrester-WMF set Security to None.

I don't think this is actually HHVM-specific. I think the issue is that the HHVM runs a broader suite of tests (more repos). However, the point still holds.

Krinkle claimed this task.Mar 9 2015, 6:40 PM
Krinkle renamed this task from mediawiki-extensions-hhvm does not run for Flow to mediawiki-extensions-hhvm should run for all covered extensions (eg. Flow).Mar 9 2015, 7:17 PM

Change 195335 had a related patch set uploaded (by Krinkle):
Enable 'mediawiki-extensions-{hhvm,zend}' in all extensions it covers

https://gerrit.wikimedia.org/r/195335

Change 195335 merged by jenkins-bot:
Enable 'mediawiki-extensions-{hhvm,zend}' in all extensions it covers

https://gerrit.wikimedia.org/r/195335

Krinkle closed this task as Resolved.EditedMar 9 2015, 7:46 PM

Fixed.

Verified via recheck on https://gerrit.wikimedia.org/r/#/c/195330/.

It was basically already set up that way, but Flow got left out somehow when the list was last synchronised.