⚓ T92000 PHPUnit: make tests independent of global CN config variables

Subject	Repo	Branch	Lines +/-
Clean up database switching	mediawiki/extensions/CentralNotice	master	+31 -60
Clean up database switching	mediawiki/extensions/CentralNotice	master	+31 -60
Clean up database switching	mediawiki/extensions/CentralNotice	master	+28 -64

Status	Assigned	Task
Resolved	hashar	T53908 Jenkins should flag usage of deprecated features
Resolved	hashar	T50002 Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown
Resolved	AndyRussG	T86092 CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests
Resolved	None	T91763 Fix "PHP Warning: No route to fetch banner choice data configured" in QUnit runs
Resolved	None	T92000 PHPUnit: make tests independent of global CN config variables

AndyRussG created this task.Mar 9 2015, 7:56 PM

AndyRussG raised the priority of this task from to Needs Triage.

AndyRussG updated the task description. (Show Details)

AndyRussG added a project: MediaWiki-extensions-CentralNotice.

AndyRussG subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2015, 7:56 PM

Aklapper triaged this task as Low priority.Mar 10 2015, 11:40 AM

Change 181238 had a related patch set uploaded (by Awight):
Clean up database switching

https://gerrit.wikimedia.org/r/181238

gerritbot added a project: Patch-For-Review.Mar 16 2015, 7:50 AM

Change 197003 had a related patch set uploaded (by Awight):
Use the one-argument form of wfGetDB when fetching the primary db

https://gerrit.wikimedia.org/r/197003

Change 197003 abandoned by Awight:
Clean up database switching

Reason:
squashed.

https://gerrit.wikimedia.org/r/197003

Change 197003 restored by Awight:
Clean up database switching

Reason:
ooops.

https://gerrit.wikimedia.org/r/197003

Change 197003 abandoned by Awight:
Clean up database switching

Reason:
aha! That was the one I meant to abandon.

https://gerrit.wikimedia.org/r/197003

Change 181238 merged by jenkins-bot:
Clean up database switching

https://gerrit.wikimedia.org/r/181238

Change 197745 had a related patch set uploaded (by Awight):
Clean up database switching

https://gerrit.wikimedia.org/r/197745

@AndyRussG @awight should this be in the sprint? it's "low" priority.

@atgo as is prone to happen when apples go to the juice farm, this turned out to be the blocker for the fix that unblocked cross-browser tests, so fixing this allowed us to fix that which fixed the other thing.