Page MenuHomePhabricator

Hover state on buttons
Closed, ResolvedPublic1 Estimated Story Points

Description

Some concerns with the current bevel on hover states:

  • Causes vertical misalignment on label.
  • Does not work with flush buttons i.e.: on toolbars (looks like bottom border instead of bevel).
  • Focus state == Active state

Related Objects

Event Timeline

violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)

Do we have any alternative ideas?

@Prtksxna Something similar to this. Check hover states for normal buttons and quiet buttons

where we change the background color on hover.

P.S. ignore the focus and active states for now. just check hover states for all buttons.

Jdforrester-WMF claimed this task.
Jdforrester-WMF subscribed.

This was done as part of T98806: OOJS UI: Update button spec in OOjs UI 0.11.3

I really liked the previous look for the buttons. I understand that a lot of work went into this change, what with the mockups and specs and all, but couldn't we have done something else to solve the issues @violetto pointed out?

For instance, let's take "focus state == active state". (Chosen because I wasn't too sure what the other two issues were.) There must be another way to represent the focus state for a button. The Google Play store has buttons that very closely resemble the previous look, and they solved the focus problem by:

  • changing the background color and adding a bevel on hover, and
  • changing the background color to a different color and adding a bevel on the top on focus.

I know there are other solutions out there. (This page, for example, took a few seconds of Googling.)

TL;DR I liked the previous look more.