Assertion failure from kibana logs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Mar 10 2015, 4:35 AM

Description

On these pages, and possibly others

enwiki:Circassian_diaspora:634294137
enwiki:Kurdish_population:646932586
enwiki:Comparison_of_file_systems:649115548
fawiki:الگو:Fb_r2_header:10196307
enwiki:Largest_Armenian_diaspora_communities:646932586

AssertionError: false == true at Console.assert (console.js:102:23) 
  at TableFixups.collectAttributishContent (/srv/deployment/parsoid/deploy/src/lib/dom.t.TableFixups.js:163:12) 
  at TableFixups.reparseTemplatedAttributes (/srv/deployment/parsoid/deploy/src/lib/dom.t.TableFixups.js:219:32) 
  at TableFixups.handleTableCellTemplates (/srv/deployment/parsoid/deploy/src/lib/dom.t.TableFixups.js:371:7)
  at DOMTraverser.callHandlers (/srv/deployment/parsoid/deploy/src/lib/domTraverser.js:42:31) 
  at DOMTraverser.traverse (/srv/deployment/parsoid/deploy/src/lib/domTraverser.js:80:17) 
  at DOMTraverser.traverse (/srv/deployment/parsoid/deploy/src/lib/domTraverser.js:89:10) 
  at DOMTraverser.traverse (/srv/deployment/parsoid/deploy/src/lib/domTraverser.js:89:10) 
  at DOMTraverser.traverse (/srv/deployment/parsoid/deploy/src/lib/domTraverser.js:89:10) 
  at DOMTraverser.traverse (/srv/deployment/parsoid/deploy/src/lib/domTraverser.js:89:10)

Related Objects

Mentioned In: rGPAR9903b4e7fb63: T92177: Fix assertion failure in td-fixup code
rGPARb3c7267dc2b8: Merge "T92177: Fix assertion failure in td-fixup code"

Event Timeline

ssastry created this task.Mar 10 2015, 4:35 AM

ssastry raised the priority of this task from to High.

ssastry updated the task description. (Show Details)

ssastry added a project: Parsoid.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2015, 4:35 AM

Enough to replicate the assertion failure

{| 
|-
| {{flag|Iran}} || {{nts|0}} {{N/A}}
|}

Unrelated however is this "feature":

{|
| <div>foobar</div> <span style="display:none" class="sortkey">5000000000000000000</span>0 style="background: #ececec; color: grey; vertical-align: middle; text-align: center;" class="table-na" | <small>N/A</small>
|}

This parses a td-cell to which the style and class attributes are applies .. and all the intervening html is simply and silently dropped. Of course, Parsoid handles this differently .. late at night .. so, recording this here to see what we want to do about this separately.

Change 195604 had a related patch set uploaded (by Subramanya Sastry):
T92177: Fix assertion failure in td-fixup code

https://gerrit.wikimedia.org/r/195604

gerritbot added a project: Patch-For-Review.Mar 10 2015, 5:46 PM

Change 195604 merged by jenkins-bot:
T92177: Fix assertion failure in td-fixup code

https://gerrit.wikimedia.org/r/195604

ssastry closed this task as Resolved.Mar 24 2015, 4:44 PM

ssastry claimed this task.

ssastry mentioned this in rGPAR9903b4e7fb63: T92177: Fix assertion failure in td-fixup code.Apr 8 2015, 4:28 PM

Diffusion mentioned this in rGPARb3c7267dc2b8: Merge "T92177: Fix assertion failure in td-fixup code".Apr 8 2015, 4:28 PM