Page MenuHomePhabricator
Create Task
Maniphest T92265

Remove wrong "Gregorian" display from diff views
Closed, InvalidPublic
Actions

Description

I'm creating a separate ticket for https://github.com/DataValues/Time/pull/32 now. This patch is so simple and so important, I really don't understand why it's just sitting there for 5 weeks now. It's so wrong, it even qualifies for a backport. Can we please, please move on with this giant mess of time-related issues?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use HtmlTimeFormatter in TimeDetailsFormattermediawiki/extensions/Wikibasemaster+37 -11
Drop pointless time formatter delegationmediawiki/extensions/Wikibasewmf/1.25wmf19+1 -1
Drop pointless time formatter delegationmediawiki/extensions/Wikibasemaster+1 -1
Drop pointless time formatter delegationmediawiki/extensions/Wikibasemaster+3 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Mar 10 2015, 1:41 PM
thiemowmde claimed this task.
thiemowmde raised the priority of this task from to Unbreak Now!.
thiemowmde updated the task description. (Show Details)
thiemowmde added projects: Wikidata, § Wikidata-Sprint-2015-02-25.
thiemowmde subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2015, 1:41 PM
thiemowmde added a parent task: T87312: [Bug] User interface displays false birth and death dates.Mar 10 2015, 1:42 PM
thiemowmde added a parent task: T87764: Bugs related to time datatype (tracking).
thiemowmde added a project: Patch-For-Review.
thiemowmde moved this task from Backlog to Review on the § Wikidata-Sprint-2015-02-25 board.
Liuxinyu970226 subscribed.Mar 10 2015, 1:44 PM
thiemowmde added a project: DataValues.Mar 10 2015, 1:45 PM
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-11.Mar 11 2015, 12:31 PM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-11 board.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 12 2015, 11:31 AM
gerritbot subscribed.Mar 13 2015, 8:16 PM

Change 195883 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop pointless time formatter delegation

https://gerrit.wikimedia.org/r/195883

gerritbot added a comment.Mar 16 2015, 11:19 AM

Change 196635 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Use HtmlTimeFormatter in TimeDetailsFormatter

https://gerrit.wikimedia.org/r/196635

thiemowmde added a comment.Mar 16 2015, 11:29 AM

https://github.com/DataValues/Time/pull/32 completely removes the "display calendar model" feature from the class. This is not necessary, the feature can stay, it just needs to be reworked. Please review the resubmission https://github.com/DataValues/Time/pull/49 instead.

gerritbot added a comment.Mar 16 2015, 1:24 PM

Change 195883 merged by jenkins-bot:
Drop pointless time formatter delegation

https://gerrit.wikimedia.org/r/195883

gerritbot added a comment.Mar 16 2015, 1:58 PM

Change 197039 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop pointless time formatter delegation

https://gerrit.wikimedia.org/r/197039

gerritbot added a comment.Mar 16 2015, 2:01 PM

Change 197039 abandoned by Thiemo Mättig (WMDE):
Drop pointless time formatter delegation

https://gerrit.wikimedia.org/r/197039

gerritbot added a comment.Mar 16 2015, 2:07 PM

Change 197040 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop pointless time formatter delegation

https://gerrit.wikimedia.org/r/197040

gerritbot added a comment.Mar 16 2015, 2:41 PM

Change 197040 merged by jenkins-bot:
Drop pointless time formatter delegation

https://gerrit.wikimedia.org/r/197040

gerritbot added a comment.Mar 16 2015, 3:10 PM

Change 196635 merged by jenkins-bot:
Use HtmlTimeFormatter in TimeDetailsFormatter

https://gerrit.wikimedia.org/r/196635

Tobi_WMDE_SW subscribed.Mar 17 2015, 9:54 AM

Am I getting this right? https://github.com/DataValues/Time/pull/49 is the only changeset left to resolve this?

Tobi_WMDE_SW mentioned this in T88437: figure out and fix current state of time storage and display.Mar 17 2015, 10:28 AM
thiemowmde lowered the priority of this task from Unbreak Now! to Low.Mar 17 2015, 1:17 PM

@Tobi_WMDE_SW, yes, the line https://github.com/DataValues/Time/pull/49/files#diff-231023e756f084705b0ead65063eb61eL71 in that patch is the only one left. Currently this class is not used any more, so the priority is low. But I would like to keep this task open until the last patch is merged.

Liuxinyu970226 unsubscribed.Mar 17 2015, 3:50 PM
Diffusion mentioned this in rMEXT3d8e2ca17f74: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 23 2015, 3:55 PM
Diffusion mentioned this in rMEXT2cd46d2dc87c: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….
thiemowmde mentioned this in rEWBAb91e056bda45: Use HtmlTimeFormatter in TimeDetailsFormatter.Mar 23 2015, 3:57 PM
thiemowmde mentioned this in rEWBAdca6ace18fd6: Drop pointless time formatter delegation.
thiemowmde mentioned this in rEWBA2a64ea002f5f: Drop pointless time formatter delegation.
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-24.Mar 24 2015, 3:07 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-24 board.Mar 24 2015, 3:10 PM
thiemowmde closed this task as Invalid.Mar 25 2015, 5:10 PM

I'm closing this for now. I will split the code not related to calendar models from https://github.com/DataValues/Time/pull/49 and make that a separate patch. The remaining discussion about the meaning of the calendar model will be tracked in an other ticket.

Tobi_WMDE_SW moved this task from Review to Done on the § Wikidata-Sprint-2015-03-24 board.Mar 26 2015, 10:26 AM
daniel moved this task from Review to Done on the § Wikidata-Sprint-2015-03-11 board.Mar 30 2015, 1:10 PM
thiemowmde mentioned this in T96137: Release and use data-values/time 0.7.Apr 15 2015, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits