Page MenuHomePhabricator

upgrade salt on deployment-prep to 2014.7
Closed, ResolvedPublic

Description

Testing upgrade of salt on deployment-prep; this involves pinning the salt ppa repo, adding that repo to the apt sources list, doing the update, and testing.

Event Timeline

ArielGlenn claimed this task.
ArielGlenn raised the priority of this task from to Normal.
ArielGlenn updated the task description. (Show Details)
ArielGlenn added a subscriber: ArielGlenn.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2015, 3:06 PM

Salt-common, salt-master and salt-minion have been updated across deployment-prep. 2014.7 salt-syndic has been installed on deployment-salt. I have removed the salt ppa repo from sources list now. New deployment-prep instances will not get the latest salt but the old version minions can talk to the new master without problems.

Due to salt issue https://github.com/saltstack/salt/issues/18317 which will be fixed in the next minor release of 2014.7, git deploy sync in trebuchet-trigger does not work. I have edited /usr/share/pyshared/trigger/drivers/trebuchet/local.py in place on deployment-bastion, as that is the only location that trigger is installed. It was a two line workaround. This removes the ability to use the --force argument to git deploy sync, which is why I will not build packages and put them in the production repo.

Until the new salt point release comes out and is verified to work, I don't consider this upgrade complete, and we cannot move to upgrade in production, nor in the rest of labs.

hashar added a subscriber: hashar.EditedMar 10 2015, 3:37 PM

As a workaround, we could rebuild the ppa package and add the three commits mentioned on issue 18317 then mark it with -wmf1 or something.

The commits are:

https://github.com/saltstack/salt/pull/20992/commits
https://github.com/saltstack/salt/pull/21047/commits

Or build a package using a snapshot or their branch 2014.7 which has them.

I can but I'd have to build it for 3 platforms, and I'd rather just wait the couple of weeks for the point release.

well 4 platforms actually...

Packages out two days ago, will be testing with those on deployment prep shortly.

ArielGlenn closed this task as Resolved.May 8 2015, 7:42 AM

This upgrade is complete. While git deploy works fine, this is in part due to local modifications to code in the trigger package which were made during the previous upgrade. A more permanent fix is needed which will be tracked in another task.