Page MenuHomePhabricator
Create Task
Maniphest T92428

Show "we were unable to make citation for you" instead of offering completely empty template.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Citoid is an extension that allows you to add citations from a url or other identifier from the Visual Editor.

Getting started:

Install mediawiki, enable citoid, and make sure to import the listed templates:
https://www.mediawiki.org/wiki/Citoid#Installation_2

We should show the "we could not make a citation for you" error if no template parameters have been added to the citation. We could check to see if the template is empty of parameters before offering up the suggestion in the inspector. You can mimic this behaviour locally by removing the template data ( i.e. content between <templatedata> tags in Template/Cite_web/doc) and then inserting a citation in visual editor from a url that would be a web citation i.e. http://twitter.com.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ve.ui.CiteFromIdInspector: Add check for empty templatesEthanleemediawiki/extensions/Citoidmaster+7 -1
Customize query in gerrit

Event Timeline

Mvolz created this task.Mar 11 2015, 6:49 PM
Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz moved this task to Extension on the Citoid board.
Mvolz added subscribers: Mvolz, • KHammerstein, Mooeypoo.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2015, 6:49 PM
Jdforrester-WMF triaged this task as Low priority.Apr 27 2015, 8:15 PM
Jdforrester-WMF set Security to None.
Mvolz renamed this task from Have some sort of error if there is no map, or no matching template parameters, associated with a type. to Show "we were unable to make citation for you" instead of offering completely empty template. .May 6 2015, 5:47 PM
Mvolz claimed this task.May 11 2015, 10:27 AM
Mvolz added a project: good first task.Jun 25 2015, 2:11 AM
Mvolz removed Mvolz as the assignee of this task.Aug 5 2015, 8:18 AM
TheresNoTime added a project: Google-Code-In-2016.Oct 27 2016, 8:31 AM
TheresNoTime subscribed.

Willing to mentor for Google-Code-In-2016

Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 27 2016, 8:31 AM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Mvolz added a comment.Oct 27 2016, 11:59 AM
In T92428#2747721, @Samtar wrote:

Willing to mentor for Google-Code-In-2016

I would caution that whilst the actual change itself is probably okay, this one requires A LOT of set-up/yak shaving to get to that point. I think in the past we've avoided doing VE tasks for code-in for that reason? Now that vagrant is more mature, maybe it's less of an issue?

TheresNoTime added a comment.Oct 27 2016, 12:10 PM

@Mvolz you may well be right - I'll give this a once over and see what sort of setup would be required. I imagine vagrant will significantly speed up getting the development environment up and running, but this could be a bit too much for Code-In

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Nov 8 2016, 8:05 PM
Aklapper added a comment.Nov 27 2016, 9:59 PM

@Samtar: Any clarifications regarding expectations and scope when it comes to GCI? Could this be broken down into small sized tasks or not?

Mvolz added a comment.Nov 27 2016, 10:02 PM

No, definitely not. It's a single task. Just with a lot of yak shaving :).

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 28 2016, 12:01 AM

Imported as https://codein.withgoogle.com/tasks/5709684757495808/

Mvolz added a comment.Nov 28 2016, 12:16 AM

On second reading, this is really two distinct tasks (but still difficult for the same reasons.)

Mvolz updated the task description. (Show Details)Nov 28 2016, 12:17 AM

If there's no matching map, we do already have an error for that (unable to make a citation for you) and I'm not sure we should add a special one in. It'd probably just confuse users. So I have removed that part of the task.

Mvolz updated the task description. (Show Details)Nov 28 2016, 12:20 AM
gerritbot subscribed.Dec 20 2016, 11:58 AM

Change 326112 had a related patch set uploaded (by Mvolz):
ve.ui.CiteFromIdInspector: Add check for empty templates

https://gerrit.wikimedia.org/r/326112

gerritbot added a project: Patch-For-Review.Dec 20 2016, 11:58 AM
Mvolz closed this task as Resolved.Dec 20 2016, 12:00 PM
gerritbot added a comment.Jan 5 2017, 1:39 PM

Change 326112 merged by jenkins-bot:
ve.ui.CiteFromIdInspector: Add check for empty templates

https://gerrit.wikimedia.org/r/326112

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 5 2017, 2:00 PM
Jdforrester-WMF assigned this task to ethanlee.Jan 5 2017, 7:02 PM
Jdforrester-WMF set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits