Page MenuHomePhabricator
Create Task
Maniphest T92430

Allow multiple instances of the same type of widget per board
Closed, DeclinedPublic
Actions

Description

Many widget modify modals are currently using bootstrap, and sharing a single modal id. This only lets you configure one of each type per board. We should switch the modals to hide/display based on a knockout binding.

Widget charts are also binding to specific element IDs. We should use a custom binding to attach each to the correct element within the component.

Details

SubjectRepoBranchLines +/-
Use C3 binding in all widgetswikimedia/fundraising/dashmaster+166 -157
Make a C3 knockout bindingwikimedia/fundraising/dashmaster+48 -22
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Mar 11 2015, 7:00 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added a project: Fundraising Dash (obsolete).
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2015, 7:00 PM
• atgo renamed this task from Multiple fraud widgets share one modify modal to Allow multiple fraud widgets per board.Mar 12 2015, 9:26 PM
• atgo triaged this task as Low priority.
• atgo set Security to None.
Ejegg renamed this task from Allow multiple fraud widgets per board to Allow multiple instances of the same type of widget per board.Mar 23 2015, 8:39 PM
Ejegg updated the task description. (Show Details)
gerritbot subscribed.Mar 23 2015, 8:41 PM

Change 198148 had a related patch set uploaded (by Ejegg):
Make a C3 knockout binding

https://gerrit.wikimedia.org/r/198148

gerritbot added a project: Patch-For-Review.Mar 23 2015, 8:41 PM

Change 198821 had a related patch set uploaded (by Ejegg):
Use C3 binding in all widgets

https://gerrit.wikimedia.org/r/198821

gerritbot added a comment.Mar 25 2015, 9:21 PM

Change 198148 merged by Ssmith:
Make a C3 knockout binding

https://gerrit.wikimedia.org/r/198148

Ejegg mentioned this in rWFDAb9ab752becb2: Make a C3 knockout binding.Mar 25 2015, 9:21 PM
gerritbot added a comment.Mar 25 2015, 10:04 PM

Change 198821 merged by jenkins-bot:
Use C3 binding in all widgets

https://gerrit.wikimedia.org/r/198821

Ejegg mentioned this in rWFDA76e18a11c18e: Use C3 binding in all widgets.Mar 25 2015, 10:05 PM
Ejegg closed this task as Declined.Jan 10 2022, 8:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL