https://gerrit.wikimedia.org/r/#/c/196279/ broke the site because it introduced whitespace before the opening <?php marker in a configuration file that is loaded on every request. scap should check for that.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Check for any content before opening <?php tag prior to syncing | mediawiki/tools/scap | master | +71 -2 |
Related Objects
Related Objects
- Mentioned In
- rMSCA6dd402160658: check_php_syntax: Check for any content before opening <?php tag
rMSCA2b1ed48eff0c: check_php_syntax: Check for any content before opening <?php tag
rMSCA86c179e13fa7: check_php_syntax: Check for any content before opening <?php tag
rMSCA096e0c114ba0: check_php_syntax: Check for any content before opening <?php tag
rMSCA3c9ff1f53451: Improved test for content preceeding <?php opening tag.
rMSCA508e86145b26: Improved test for content preceeding <?php opening tag.
rMSCA575a5b5f8b5a: Check for any content before opening <?php tag prior to syncing
T92531: add a check for whitespace before leading <?php - Mentioned Here
- rEMAT5a50bb312c4b: Remove U+FEFF before opening <?php tag
P392 stuff before <?php
Event Timeline
Comment Actions
Things with stuff before <?php in core+extensions+skins:
Some are shebangs, other look like legit errors (MathMLTest).
Comment Actions
Change 196306 had a related patch set uploaded (by Legoktm):
check_php_syntax: Check for any content before opening <?php tag
Comment Actions
Math was fixed in 5a50bb312c4bd7355835e6939508687b5a7f796b, and that looked like the only issue with WMF-deployed code.
Comment Actions
Change 196306 merged by jenkins-bot:
Check for any content before opening <?php tag prior to syncing