Page MenuHomePhabricator
Create Task
Maniphest T92551

RL manifest for OOjs UI icon packs should be better
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  • Generated from a JSON file in the theme
  • Use ResourceLoaderImageModule
  • Map to .mw-icon-<whatever> classes in addition to .oo-ui-icon-<whatever>

Details

SubjectRepoBranchLines +/-
Use ResourceLoaderImageModule to serve icons for OOjs UImediawiki/coremaster+738 -4 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 12 2015, 7:31 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: OOUI, MediaWiki-ResourceLoader, VisualEditor, Technical-Debt.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2015, 7:31 PM
Legoktm subscribed.Mar 12 2015, 7:37 PM

RLIM?

Legoktm updated the task description. (Show Details)Mar 12 2015, 7:38 PM
Legoktm set Security to None.
matmarex added a subtask: T78215: ResourceLoaderImage module css rules should be more configurable.Mar 17 2015, 5:02 PM
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.Mar 18 2015, 2:04 AM
matmarex mentioned this in T45591: Link translatable help pages on mediawiki.org from the relevant special pages, actions etc..Mar 22 2015, 11:53 AM
matmarex raised the priority of this task from Medium to High.Mar 22 2015, 10:13 PM
Jdforrester-WMF closed subtask T78215: ResourceLoaderImage module css rules should be more configurable as Resolved.Mar 29 2015, 10:32 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.Mar 30 2015, 9:37 PM
Jdforrester-WMF edited a custom field.Apr 1 2015, 6:58 PM
matmarex closed subtask T94731: Must be able to combine ResourceLoaderImageModule's icon CSS and regular CSS files in one module as Declined.Apr 2 2015, 4:52 PM
Jdforrester-WMF closed subtask T93669: colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule as Resolved.Apr 2 2015, 10:23 PM
matmarex added a comment.Apr 3 2015, 2:15 PM

I'm going to do this after we upgrade MediaWiki to use OOjs UI v0.9.6 (in a separate commit).

gerritbot subscribed.Apr 7 2015, 4:34 PM

Change 202430 had a related patch set uploaded (by Bartosz Dziewoński):
Use ResourceLoaderImageModule to serve icons for OOjs UI

https://gerrit.wikimedia.org/r/202430

gerritbot added a project: Patch-For-Review.Apr 7 2015, 4:34 PM
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 8 2015, 7:27 PM
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Apr 8 2015, 7:42 PM
matmarex lowered the priority of this task from High to Medium.Apr 14 2015, 4:58 PM

(Updating priority to reflect reality.)

matmarex closed subtask T94733: ResourceLoaderImageModule does no cache invalidation after icons change as Resolved.Apr 15 2015, 9:54 PM
matmarex added a comment.Apr 16 2015, 5:04 PM

Idea dump:

We want to use ResourceLoaderImageModule to serve icons for OOjs UI in MediaWiki since it gives us better per-language icons support and brings us ever-so-slightly closer to being able to master the MediaWiki theme for OOUI in the mediawiki/core repository, which AIUI we also want to do at some point.

Possible solutions:

  • Keep using what we have. No ResourceLoaderImageModule, lots of silly duplicated code in Resources.php, annoying update process if we add/remove icon packs. This is now in master.
  • Use the original JSON files from OOUI source and teach ResourceLoaderImageModule to pull data directly from them. I think that's pretty gnarly. That is what the proposed patch does now.

Hopefully better idea: generate the ResourceLoader module data for MediaWiki directly. This would be a separate file that we'd load in ResourceLoader.php near "// Register core modules" code. (We already have such a thing in LocalisationCache for OOUI localisation.)

  • We could make this PHP code blob like in Resources.php or a JSON file with similar structure. JSON would probably require some custom caching in order not to affect page load times, Legoktm says it's possible. PHP code would be nasty, that's not a portable format, but possibly easier to use in this scenario.
  • We could generate this from OOUI build process (which would shatter the illusion of OOUI being independent from MediaWiki) or from a MediaWiki maintenance script ran during update, from update-oojs-ui.sh (would make the update process somewhat nastier?).
matmarex added a comment.Apr 16 2015, 5:05 PM

I am not very happy with the current state of the patch, but I'm also not sure if putting more work into it is worth it.

Jdforrester-WMF added a parent task: T76633: Move the "WikimediaUI" OOjs UI theme to the MediaWiki repo.Apr 16 2015, 5:10 PM
Jdforrester-WMF moved this task from Planned Maintenance to Blocked on the VisualEditor board.Apr 16 2015, 9:15 PM
Krinkle moved this task from Inbox to Assigned on the MediaWiki-ResourceLoader board.Apr 28 2015, 6:24 PM
gerritbot added a comment.Apr 28 2015, 8:21 PM

Change 202430 merged by jenkins-bot:
Use ResourceLoaderImageModule to serve icons for OOjs UI

https://gerrit.wikimedia.org/r/202430

matmarex mentioned this in rMW9e5c3e9521a8: Use ResourceLoaderImageModule to serve icons for OOjs UI.Apr 28 2015, 8:21 PM
Jdforrester-WMF added a comment.Apr 28 2015, 8:22 PM

Done?

matmarex closed this task as Resolved.Apr 28 2015, 9:17 PM
matmarex subscribed.

Done.

Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 28 2015, 9:32 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Apr 29 2015, 9:36 PM
matmarex mentioned this in T97793: Audit icon names in OOjs UI and MobileFrontend for conflicts.May 1 2015, 4:52 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.May 6 2015, 12:57 AM
Jdforrester-WMF removed a project: Patch-For-Review.May 6 2015, 10:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL