Page MenuHomePhabricator
Create Task
Maniphest T92563

Find and eradicate mixins that have parent classes in OOUI
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Find and eradicate mixins that have parent classes. They should have them mixed in instead, as the inheritance chain is ignored when mixing in a mixin.

  • GroupWidget (-> GroupElement via .parent)

Details

SubjectRepoBranchLines +/-
GroupWidget: Mix in GroupElement, rather than inherit from itoojs/uimaster+4 -7
Customize query in gerrit

Event Timeline

matmarex created this task.Mar 12 2015, 9:03 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: OOUI, VisualEditor.
matmarex added subscribers: matmarex, • TrevorParscal, Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2015, 9:03 PM
matmarex added a subtask: T91565: OOUI's GroupWidget and ItemWidget could possibly die.Mar 12 2015, 9:03 PM
Jdforrester-WMF renamed this task from Find and eradicate mixins that have parent classes to Find and eradicate mixins that have parent classes in OOUI.Sep 2 2015, 9:38 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF edited projects, added Technical-Debt; removed VisualEditor.
Jdforrester-WMF set Security to None.
• Prtksxna subscribed.Sep 3 2015, 5:00 AM
Danny_B moved this task from Unsorted to Needs research on the Technical-Debt board.Jan 23 2016, 9:58 AM
matmarex added a comment.May 27 2016, 6:16 PM

Neither DraggableGroupElement nor LookupElement have parent classes.

matmarex updated the task description. (Show Details)May 27 2016, 6:16 PM
matmarex updated the task description. (Show Details)May 27 2016, 6:19 PM
matmarex claimed this task.May 27 2016, 6:26 PM
gerritbot subscribed.May 27 2016, 6:30 PM

Change 291297 had a related patch set uploaded (by Bartosz Dziewoński):
GroupWidget: Mix in GroupElement, rather than inherit from it

https://gerrit.wikimedia.org/r/291297

gerritbot added a project: Patch-For-Review.May 27 2016, 6:30 PM
Jdforrester-WMF closed this task as Resolved.May 30 2016, 3:58 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF subscribed.

The string @extends OO.ui.mixin no longer appears after that one. :-)

Jdforrester-WMF removed a subtask: T91565: OOUI's GroupWidget and ItemWidget could possibly die.May 30 2016, 3:59 PM
Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.17.3 on the OOUI board.May 30 2016, 4:02 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.3); removed OOUI.
gerritbot added a comment.May 30 2016, 4:08 PM

Change 291297 merged by jenkins-bot:
GroupWidget: Mix in GroupElement, rather than inherit from it

https://gerrit.wikimedia.org/r/291297

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL