Page MenuHomePhabricator

Add Github plugin to Gerrit to support 2 way sync
Closed, DeclinedPublic

Description

The Apps team would like to be able to accept pull requests on Github from the community.

To do this we need to a way to convert pull requests into patch sets on Gerrit.

This functionality (I believe) previously existed, but is no longer working and/or supported.

After an internet search, we discovered the following plugin:
https://gerrit.googlesource.com/plugins/github/

This looks like a good way to support this activity.

Could you let us know if it possible for us to install this plug in, or if not other options to support the 2 way syncing behavior?

Thanks!

Event Timeline

Fjalapeno raised the priority of this task from to Needs Triage.
Fjalapeno updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2015, 1:40 AM
Fjalapeno set Security to None.
QChris closed this task as Declined.Mar 14 2015, 12:14 PM
QChris claimed this task.
QChris added a subscriber: QChris.

It seems that WMF is sold on moving code-review to phabricator and not update our gerrit.

Our gerrit is currently at an old 2.8 version.
And the corresponding 2.8 versions of the github plugin did not work as expected when I last tested them.

Hence, declining :-(

@QChris do you happen to have a link to a doc which provides more background info on this issue? Also, I've heard various estimates on how long it will be until Diffusion is ready for mainstream use (~6 months). Further, you mentioned that Diffusion won't support build server integrations (e.g. Jenkins). Is there any way we can make a reasonable investment to improve gerrit while we wait for Diffusion to reach parity?

QChris added a subscriber: demon.Mar 18 2015, 9:37 PM

@QChris do you happen to have a link to a doc which provides more background info on this issue? [...]

The relevant bug seems to be T18 (That bug also has a rough timeline).

The main decision to move from gerrit seems to stem from https://www.mediawiki.org/wiki/Requests_for_comment/Phabricator and the discussions around it.

If you need more information about the move, I guess @demon would know more.

Also, I've heard various estimates on how long it will be until Diffusion is ready for mainstream use (~6 months).

No clue here. T18 has a rough timeline, which points to June the latest.

Further, you mentioned that Diffusion won't support build server integrations (e.g. Jenkins). Is there any way we can make a reasonable investment to improve gerrit while we wait for Diffusion to reach parity?

I think that's a question for WMF people to answer. Up to now, I only heard that WMF will not invest in Gerrit further. @demon would know better.

General timeline: https://www.mediawiki.org/wiki/Phabricator#Migration_timeline - some dates might be too optimistic. Dates in T18 are outdated. T560 is the main next task to concentrate on when it comes to Gerrit/Differential. (Diffusion is the repository browser in Phabricator).