Page MenuHomePhabricator
Create Task
Maniphest T92728

Do not show header on Special:Tags when there are no tags
Closed, ResolvedPublic
Actions

Description

Looking at Special:Tags without any tags gives just a header.
Skip the header to have not a empty table there. Not sure if there should be a message or not.

Details

SubjectRepoBranchLines +/-
Remove table header from Special:Tags when there are no tagsmediawiki/coremaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Mar 14 2015, 2:51 PM
Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added projects: MediaWiki-Change-tagging, MediaWiki-Special-pages.
Umherirrender subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2015, 2:51 PM
01tonythomas subscribed.Mar 16 2015, 6:02 AM

If someone finds it difficult to reproduce the same ( http://mediawiki-verp.wmflabs.org/wiki/Special:Tags )
*no tags was created in my labs instance :)

01tonythomas mentioned this in T76199: Goal: Newsletter extension for MediaWiki.Mar 16 2015, 6:02 AM
Tinaj1234 subscribed.Mar 16 2015, 12:21 PM

I suppose a message wouldn't hurt. I guess the usual message on empty Special pages is "There are no results for this report". Or since the page already has a text on it saying "This page lists the tags that the software may mark an edit with, and their meaning.", a new message can be avoided ?

Tinaj1234 claimed this task.Mar 16 2015, 12:21 PM
Tinaj1234 set Security to None.
Aklapper triaged this task as Low priority.Mar 16 2015, 12:45 PM
gerritbot subscribed.Mar 16 2015, 7:39 PM

Change 197119 had a related patch set uploaded (by Tinaj1234):
Remove table header from Special:Tags when there are no tags

https://gerrit.wikimedia.org/r/197119

gerritbot added a project: Patch-For-Review.Mar 16 2015, 7:39 PM
gerritbot added a comment.Mar 20 2015, 4:03 PM

Change 197119 merged by jenkins-bot:
Remove table header from Special:Tags when there are no tags

https://gerrit.wikimedia.org/r/197119

Umherirrender closed this task as Resolved.Mar 20 2015, 4:04 PM
Tinaj1234 mentioned this in T93583: GSoC'15 Proposal for Newsletter Extension Project.Mar 23 2015, 2:05 PM
Umherirrender mentioned this in rMW12f36b502da6: Remove table header from Special:Tags when there are no tags.Mar 23 2015, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL