Style modules should be considered "ready" when they are applied to a page
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	He7d3r
	Mar 14 2015, 10:51 PM

Description

When I go to
https://en.wikipedia.org/w/index.php?diff=123456
and type mw.loader.getState('mediawiki.action.history.diff') in the JS console of Firefox, I get "registered". But this is a CSS-only module, so I think it should return "ready" when the CSS is being applied to the page (which is the case on diff pages).

Related Objects

Mentioned In: T49134: Move mediawiki.special.js to a separate module
T97420: Support position "bottom" for addModuleStyles
Mentioned Here: T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles

Event Timeline

He7d3r created this task.Mar 14 2015, 10:51 PM

He7d3r raised the priority of this task from to Needs Triage.

He7d3r updated the task description. (Show Details)

He7d3r added projects: MediaWiki-ResourceLoader, JavaScript.

He7d3r added subscribers: He7d3r, Krinkle.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2015, 10:51 PM

Feel free to close this as invalid if I misunderstood the intended behavior...
(an explanation is welcome in that case)

matmarex added a subtask: T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles.Mar 15 2015, 4:06 PM

This is currently the expected behavior (so: not a bug, works as designed), but the behavior is clearly suboptimal and has bitten people in the past. It recently became a bigger problem for VisualEditor and OOjs UI, so we're working on changing it on T92459. It seems that there's no bug filed for this particular result of how addModules() vs addModuleStyles() work, so I just marked the dependencies.

Aklapper triaged this task as Medium priority.Mar 17 2015, 11:19 AM

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Apr 28 2015, 5:22 PM

Krinkle mentioned this in T97420: Support position "bottom" for addModuleStyles.

Krinkle mentioned this in T49134: Move mediawiki.special.js to a separate module.Apr 28 2015, 6:39 PM

Krinkle renamed this task from CSS modules should be considered "ready" when they are applied to a page to Style modules should be considered "ready" when they are applied to a page.Jun 10 2015, 11:53 PM

Krinkle set Security to None.

Krinkle closed this task as a duplicate of T87871: Loading with addModuleStyles() should set module state to "ready".Jul 3 2015, 12:17 AM

Krinkle removed a subtask: T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles.

Krinkle moved this task from Accepted Enhancement to Backlog on the MediaWiki-ResourceLoader board.Aug 19 2016, 6:34 AM

Style modules should be considered "ready" when they are applied to a pageClosed, DuplicatePublicActions

Description

Related Objects

Event Timeline

Style modules should be considered "ready" when they are applied to a page
Closed, DuplicatePublic
Actions