Right now our test system just checks that if a file ends with _fail.php, it triggers an error/warning, and if it ends with _pass.php, it doesn't. Now that we're writing more sniffs, this testing system doesn't scale as it doesn't verify that _fail.php is failing due to that specific sniff, and same with _pass.php.
So we should be able to specify a specific sniff (possibly inferred via filename?) does or does not trigger an error.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Tests: Revamp tests to UnitTests for each Sniff | mediawiki/tools/codesniffer | master | +979 -577 |
It may be better to go towards class based unittesting (example : https://phpunit.de/getting-started.html) and use assertEquals and so on to test whether functions perform correctly.
Each Unittest can supply specific chunks of text and give ti to phpcs through stdin.
This makes sense because each test you'd want smaller tests, to make sure each thing is working. So, something like printf "<?php\nif ( 0 ) {\n}" | phpcs can be run and checked
Change 237899 had a related patch set uploaded (by TasneemLo):
Tests: Revamp tests to UnitTests for each Sniff