Templates generating non-text content, like images, are not handled correctly when deciding to show the puzzle icon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Mar 15 2015, 7:02 PM

Description

In T51806#1114817, @Etonkovidova wrote:

There is a curious case of the template: https://test2.wikipedia.org/wiki/Template:No_spam {{@}}.
Inserting {{@}} will display the icon, just as for the hidden template: 'Use British English'.

Templates generating non-text content, like images, are not handled correctly.

Related Objects
Search...

Status	Assigned	Task
Declined	None	T55205 VisualEditor: can't fix a broken template since this will result invisible
Resolved	Mooeypoo	T52633 VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings
Resolved	Mooeypoo	T51806 Hidden templates should display as an icon in-page in VisualEditor so they can be interacted with (e.g. a puzzle piece?)
Resolved	Esanders	T92773 Templates generating non-text content, like images, are not handled correctly when deciding to show the puzzle icon

Event Timeline

matmarex created this task.Mar 15 2015, 7:02 PM

matmarex raised the priority of this task from to Medium.

matmarex updated the task description. (Show Details)

matmarex added projects: VisualEditor, VisualEditor-ContentEditable.

matmarex added subscribers: Etonkovidova, Mooeypoo.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2015, 7:02 PM

This was supposed to be fixed in a followup commit, and I can't reproduce it now. The {{No spam}} template produces a square with @ in it (as it should) and without the template icon. Tested on test2 and betalabs.

Is this still happening?

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Mar 18 2015, 2:04 AM