Page MenuHomePhabricator
Create Task
Maniphest T92824

Fix compiled templates
Closed, ResolvedPublic
Actions

Description

We recently removed the handlebars makescript.

I'm now getting some error because of some bad compiled file.
I'm starting to see some other issues with current compiled templates too, I'll recompile all of them & fix whatever issue arises.

Event Timeline

matthiasmullie created this task.Mar 16 2015, 12:20 PM
matthiasmullie claimed this task.
matthiasmullie raised the priority of this task from to Needs Triage.
matthiasmullie updated the task description. (Show Details)
matthiasmullie added projects: StructuredDiscussions, Collaboration-Team-Sprint-S-2015-03-25.
matthiasmullie subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 12:20 PM
matthiasmullie updated the task description. (Show Details)Mar 16 2015, 12:35 PM
matthiasmullie set Security to None.
matthiasmullie added a comment.EditedMar 16 2015, 12:38 PM

Here's a couple of patches:

https://gerrit.wikimedia.org/r/197024
https://gerrit.wikimedia.org/r/197025
https://gerrit.wikimedia.org/r/197026
https://gerrit.wikimedia.org/r/197027
https://gerrit.wikimedia.org/r/197028
https://gerrit.wikimedia.org/r/197029
https://gerrit.wikimedia.org/r/197030
https://gerrit.wikimedia.org/r/197064

Most noticeable fixes: header & summary single-revision & diff views were broken, are now fixed.
Rest is just cleanup & removing dead files.

matthiasmullie moved this task from Sprint S - ends March 25 to Needs Code Review on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 16 2015, 12:39 PM
EBernhardson triaged this task as Medium priority.Mar 16 2015, 5:38 PM
EBernhardson moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-S-2015-03-25 board.
EBernhardson subscribed.
EBernhardson moved this task from Code Review Started to Done on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 17 2015, 4:06 PM
matthiasmullie closed this task as Resolved.Mar 20 2015, 2:32 PM
• DannyH moved this task from Done to Product Review on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 24 2015, 5:53 PM
• Mattflaschen-WMF moved this task from Product Review to Done on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 25 2015, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL