Page MenuHomePhabricator
Create Task
Maniphest T92827

Special:Captcha/image throws 500s/Internal Error for unknown captcha images
Closed, ResolvedPublic
Actions

Description

Visiting https://en.wikipedia.org/wiki/Special:Captcha/image or e.g. http://en.wikipedia.org/w/index.php?title=Special%3ACaptcha%2Fimage&wpCaptchaId=167501434 results in a 500 which a) produces graph noise & alerts, b) is uncacheable.

This isn't an internal server error as it's clearly properly handled on the server side. A 4xx range error code should be emitted; possibly even 404.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FancyCaptcha: Don't return status code 500, if no server errormediawiki/extensions/ConfirmEditmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

faidon created this task.Mar 16 2015, 1:27 PM
faidon raised the priority of this task from to Needs Triage.
faidon updated the task description. (Show Details)
faidon added a project: MediaWiki-General.
faidon subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 1:27 PM
faidon edited projects, added: ConfirmEdit (CAPTCHA extension); removed: MediaWiki-General.Mar 16 2015, 1:41 PM
faidon set Security to None.
Aklapper triaged this task as Medium priority.Mar 17 2015, 12:03 PM
Florian claimed this task.Mar 18 2015, 6:51 AM
gerritbot subscribed.Mar 18 2015, 6:59 AM

Change 197483 had a related patch set uploaded (by Florianschmidtwelzow):
FancyCaptcha: Don't return status code 500, if no server error

https://gerrit.wikimedia.org/r/197483

gerritbot added a project: Patch-For-Review.Mar 18 2015, 6:59 AM
Florian moved this task from Backlog to Awaiting Code Review on the ConfirmEdit (CAPTCHA extension) board.Mar 18 2015, 6:59 AM
Florian merged a task: T88970: bogus captchaid results in http 500, should be http 400 instead.Mar 18 2015, 8:07 AM
Florian added a subscriber: fgiunchedi.
Florian closed this task as Resolved.Mar 19 2015, 6:09 PM
Florian removed a project: Patch-For-Review.
gerritbot added a comment.Mar 19 2015, 6:14 PM

Change 197483 merged by jenkins-bot:
FancyCaptcha: Don't return status code 500, if no server error

https://gerrit.wikimedia.org/r/197483

Diffusion mentioned this in rMEXTb562d809b980: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….Mar 23 2015, 3:55 PM
Florian mentioned this in rECOEb6c22b0e02fd: FancyCaptcha: Don't return status code 500, if no server error.Mar 23 2015, 3:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits