Page MenuHomePhabricator

OOjs UI redefines font-family to sans-serif in windows and widgets when it should just inherit
Closed, ResolvedPublic

Description

OOJS UI doesn't define correct consistent (to body) font stack in windows (modal windows) and some of the widgets.

https://github.com/wikimedia/oojs-ui/search?utf8=%E2%9C%93&q=sans-serif

Event Timeline

Nirzar claimed this task.
Nirzar raised the priority of this task from to Medium.
Nirzar updated the task description. (Show Details)
Nirzar added projects: OOUI, Design.

Change 197097 had a related patch set uploaded (by Nirzar):
Defining font stack for modal windows and widgets

https://gerrit.wikimedia.org/r/197097

What do you mean by 'correct'?

@Esanders The one that defines font names in order of preference and not only the typeface style.

e.g.

font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;

instead of

font-family: sans-serif;

MediaWiki should be font agnostic. Defining fonts other than "sans-serif" or "serif" in the base code is probably not correct.

@Nirzar I understand, but why is that correct?

@Esanders & @Jorm I should have been more clear about the description, what i meant was consistent font stack. OOJS UI (and VE) uses Helvetica on Chrome and Helvetica Neue on Safari causing rendering issues in buttons. Vertical alignment specifically. This patch gives precedence to "Helvetica Neue" resulting in consistent rendering on all browsers on same operating system.

Jdforrester-WMF renamed this task from OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets to OOjs UI redefines font-family to sans-serif in windows and widgets when it should just inherit.Mar 25 2015, 9:42 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.

Change 197097 merged by jenkins-bot:
Removing extra font-family definitions, fonts will inherit from body

https://gerrit.wikimedia.org/r/197097