Page MenuHomePhabricator
Create Task
Maniphest T92858

OOjs UI redefines font-family to sans-serif in windows and widgets when it should just inherit
Closed, ResolvedPublic
Actions

Description

OOJS UI doesn't define correct consistent (to body) font stack in windows (modal windows) and some of the widgets.

https://github.com/wikimedia/oojs-ui/search?utf8=%E2%9C%93&q=sans-serif

Details

SubjectRepoBranchLines +/-
Removing extra font-family definitions, fonts will inherit from bodyoojs/uimaster+0 -3
Customize query in gerrit

Related Objects

Event Timeline

• Nirzar created this task.Mar 16 2015, 5:43 PM
• Nirzar claimed this task.
• Nirzar raised the priority of this task from to Medium.
• Nirzar updated the task description. (Show Details)
• Nirzar added projects: OOUI, Design.
• Nirzar added subscribers: • Nirzar, • TrevorParscal, • Prtksxna.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 5:43 PM
gerritbot subscribed.Mar 16 2015, 6:04 PM

Change 197097 had a related patch set uploaded (by Nirzar):
Defining font stack for modal windows and widgets

https://gerrit.wikimedia.org/r/197097

gerritbot added a project: Patch-For-Review.Mar 16 2015, 6:04 PM
Esanders subscribed.Mar 24 2015, 4:14 AM

What do you mean by 'correct'?

• Nirzar added a comment.Mar 24 2015, 4:22 AM

@Esanders The one that defines font names in order of preference and not only the typeface style.

e.g.

font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;

instead of

font-family: sans-serif;
Jorm subscribed.Mar 24 2015, 5:16 PM

MediaWiki should be font agnostic. Defining fonts other than "sans-serif" or "serif" in the base code is probably not correct.

Legoktm subscribed.Mar 24 2015, 5:17 PM
Esanders added a comment.Mar 24 2015, 5:27 PM

@Nirzar I understand, but why is that correct?

• Nirzar added a comment.Mar 24 2015, 6:27 PM

@Esanders & @Jorm I should have been more clear about the description, what i meant was consistent font stack. OOJS UI (and VE) uses Helvetica on Chrome and Helvetica Neue on Safari causing rendering issues in buttons. Vertical alignment specifically. This patch gives precedence to "Helvetica Neue" resulting in consistent rendering on all browsers on same operating system.

• Nirzar updated the task description. (Show Details)Mar 24 2015, 6:29 PM
• Nirzar set Security to None.
Jdforrester-WMF renamed this task from OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets to OOjs UI redefines font-family to sans-serif in windows and widgets when it should just inherit.Mar 25 2015, 9:42 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
gerritbot added a comment.Mar 25 2015, 9:43 PM

Change 197097 merged by jenkins-bot:
Removing extra font-family definitions, fonts will inherit from body

https://gerrit.wikimedia.org/r/197097

• Nirzar mentioned this in rGOJU9aad5195771d: Removing extra font-family definitions, fonts will inherit from body.Mar 25 2015, 9:45 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2015, 9:00 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-01_(1.25wmf24); removed OOjs-UI-next-release.Apr 7 2015, 4:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL