Page MenuHomePhabricator

LinksUpdate error happening when finalizing upload on beta
Closed, ResolvedPublic1 Story Points

Description

https://integration.wikimedia.org/ci/view/BrowserTests/view/-Dashboard/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome-sauce/537/artifact/log/Upload_more_files%3A_Upload_more_files.png

{"servedby":"deployment-mediawiki01","error":{"code":"internal_api_error_MWException","info":"[f6ca5aa9] Exception Caught: The calling convention to LinksUpdate::construct() has changed. Please see WikiPage::doEditUpdates() for an invocation example.\n","*":"#0 /srv/mediawiki/php-master/extensions/GeoData/GeoDataHooks.php(235): LinksUpdate->construct(Title, boolean)\n#1 /srv/mediawiki/php-master/includes/Hooks.php(209): GeoDataHooks::onFileUpload(LocalFile)\n#2 /srv/mediawiki/php-master/includes/filerepo/file/LocalFile.php(1454): Hooks::run(string, array)\n#3 /srv/mediawiki/php-master/includes/filerepo/file/LocalFile.php(1158): LocalFile->recordUpload2(string, string, string, array, string, User)\n#4 /srv/mediawiki/php-master/includes/upload/UploadBase.php(715): LocalFile->upload(string, string, string, integer, array, boolean, User)\n#5 /srv/mediawiki/php-master/includes/upload/UploadFromStash.php(189): UploadBase->performUpload(string, string, boolean, User)\n#6 /srv/mediawiki/php-master/includes/api/ApiUpload.php(685): UploadFromStash->performUpload(string, string, boolean, User)\n#7 /srv/mediawiki/php-master/includes/api/ApiUpload.php(143): ApiUpload->performUpload(array)\n#8 /srv/mediawiki/php-master/includes/api/ApiUpload.php(110): ApiUpload->getContextResult()\n#9 /srv/mediawiki/php-master/includes/api/ApiMain.php(1037): ApiUpload->execute()\n#10 /srv/mediawiki/php-master/includes/api/ApiMain.php(394): ApiMain->executeAction()\n#11 /srv/mediawiki/php-master/includes/api/ApiMain.php(367): ApiMain->executeActionWithErrorHandling()\n#12 /srv/mediawiki/php-master/api.php(88): ApiMain->execute()\n#13 /srv/mediawiki/w/api.php(3): include(string)\n#14 {main}"}}

It started happening on March 13th, so there's a chance that the breakage might go to production soon.

Details

Related Gerrit Patches:
mediawiki/core : wmf/1.25wmf21GeoData: grab https://gerrit.wikimedia.org/r/#/c/197300/
mediawiki/extensions/GeoData : wmf/1.25wmf21LinksUpdate needs a ParserOutput object
mediawiki/extensions/GeoData : masterLinksUpdate needs a ParserOutput object

Event Timeline

Gilles created this task.Mar 17 2015, 9:09 AM
Gilles claimed this task.
Gilles raised the priority of this task from to Unbreak Now!.
Gilles updated the task description. (Show Details)
Gilles added a project: UploadWizard.
Gilles added a subscriber: Gilles.
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 17 2015, 9:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Gilles set Security to None.
Gilles edited a custom field.

I can't repro on my VM so far :(

Change 197300 had a related patch set uploaded (by Gilles):
LinksUpdate needs a ParserOutput object

https://gerrit.wikimedia.org/r/197300

Change 197300 merged by jenkins-bot:
LinksUpdate needs a ParserOutput object

https://gerrit.wikimedia.org/r/197300

Need any more work on this, or are we done?

Change 197408 had a related patch set uploaded (by MaxSem):
LinksUpdate needs a ParserOutput object

https://gerrit.wikimedia.org/r/197408

Change 197408 merged by jenkins-bot:
LinksUpdate needs a ParserOutput object

https://gerrit.wikimedia.org/r/197408

Change 197410 had a related patch set uploaded (by MaxSem):
GeoData: grab https://gerrit.wikimedia.org/r/#/c/197300/

https://gerrit.wikimedia.org/r/197410

MaxSem closed this task as Resolved.Mar 17 2015, 11:35 PM
MaxSem added a subscriber: MaxSem.

Um, fixed?