Maniphest T92954

More descriptive, coherent names for time precision constants
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	thiemowmde
	Mar 17 2015, 12:50 PM

Tags

Referenced Files

None

Subscribers

Description

Time precision constants are currently named in PHP:

PRECISION_Ga
PRECISION_100Ma
PRECISION_10Ma
PRECISION_Ma
PRECISION_100ka
PRECISION_10ka
PRECISION_ka
PRECISION_100a
PRECISION_10a
PRECISION_YEAR
PRECISION_MONTH
PRECISION_DAY
PRECISION_HOUR
PRECISION_MINUTE
PRECISION_SECOND

And in JavaScript:

GY
MY100
MY10
MY
KY100
KY10
KY
YEAR100
YEAR10
YEAR
MONTH
DAY
HOUR
MINUTES
SECOND

There are several problems: The names are different. They contain lower case characters. They are confusing. My suggestion:

PRECISION_YEAR1G
PRECISION_YEAR100M
PRECISION_YEAR10M
PRECISION_YEAR1M
PRECISION_YEAR100K
PRECISION_YEAR10K
PRECISION_YEAR1K
PRECISION_YEAR100
PRECISION_YEAR10
PRECISION_YEAR
PRECISION_MONTH
PRECISION_DAY
PRECISION_HOUR
PRECISION_MINUTES
PRECISION_SECOND

Relevant patches:

https://github.com/DataValues/Time/pull/42 (already merged, not yet released)
https://github.com/wmde/DataValuesJavascript/pull/68
https://gerrit.wikimedia.org/r/#/c/194306/

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T87764 Bugs related to time datatype (tracking)
		Resolved		Addshore	T92954 More descriptive, coherent names for time precision constants

Event Timeline

thiemowmde created this task.Mar 17 2015, 12:50 PM

thiemowmde raised the priority of this task from to Needs Triage.

thiemowmde updated the task description. (Show Details)

thiemowmde added projects: Wikidata, DataValues.

thiemowmde subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 12:50 PM

thiemowmde added a parent task: T87764: Bugs related to time datatype (tracking).Mar 17 2015, 12:53 PM

Lydia_Pintscher triaged this task as Medium priority.Mar 17 2015, 3:52 PM

Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.

Lydia_Pintscher set Security to None.

thiemowmde updated the task description. (Show Details)Jun 16 2015, 12:46 PM

thiemowmde added subscribers: Addshore, daniel.

All patches have been merged for a rather long time now.
{{done}}